In modern distributions /proc/acpi/event is deprecated, so puppet will not apply in host.pp acpi support

Bug #1514817 reported by Alexandr Kostrikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Bartłomiej Piotrowski

Bug Description

Ubuntu 14.04 and Centos 7 does not have /proc/acpi/event because it is deprecated
https://bugzilla.redhat.com/show_bug.cgi?id=613315

But we have in https://github.com/openstack/fuel-library/blob/master/deployment/puppet/nailgun/manifests/host.pp#L130 check for acpi_event.

That could lead to situation when virtual machine supports acpi, but does not install acpid.

Changed in fuel:
importance: Medium → Low
status: New → Triaged
assignee: nobody → Bartłomiej Piotrowski (bpiotrowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/244477

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Bartłomiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/244477

Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

This is basically a tech debt – we should introduce a custom fact with list of CPU flags (from /proc/cpuinfo), and determine this way if ACPI is available.

Changed in fuel:
status: In Progress → Confirmed
assignee: Bartłomiej Piotrowski (bpiotrowski) → Fuel Library Team (fuel-library)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Bartłomiej Piotrowski (bpiotrowski)
tags: added: tech-debt
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/245020
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=8be9b816d58bdc878ba521f20f299b686a4ddc37
Submitter: Jenkins
Branch: master

commit 8be9b816d58bdc878ba521f20f299b686a4ddc37
Author: Bartłomiej Piotrowski <email address hidden>
Date: Fri Nov 13 08:50:59 2015 +0100

    Check the acpid version before starting the service

    acpid 1.x used the deprecated /proc/acpi/event interface to listen for
    ACPI events. In newer kernel releases that interface has been removed
    and acpid made to use netlink instead, making the check always evaluate
    to false on CentOS 7.

    Change-Id: I7fb44c901fcaa9006e00c8bd77a2cca32219b4ed
    Closes-bug: 1514817

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Alexandr Kostrikov (akostrikov-mirantis) wrote :

Checked it on CentOS 7.
It works with enabled acpi feature

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.