Consolidate all execs in fuelmenu

Bug #1514387 reported by Matthew Mosesohn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Matthew Mosesohn

Bug Description

All subprocess execs of shell commands should be called under a single function, instead of using a variety of hacked up methods.

Artem Roma (aroma-x)
Changed in fuel:
milestone: none → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 8.0 → 9.0
tags: added: team-bugfix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272107

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/272107
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=d2a14d489850da1327ab9aa5281c7f37d6d00db9
Submitter: Jenkins
Branch: master

commit d2a14d489850da1327ab9aa5281c7f37d6d00db9
Author: Matthew Mosesohn <email address hidden>
Date: Mon Jan 25 17:16:57 2016 +0300

    Consolidate externall shell execs

    Individual subprocess Popen and communicate calls are
    now directed through utils.execute() method.

    Fixed gateway deletion shell command in case there is
    a metric in the command output.

    Change-Id: Ic9f3432d8dc511dea0fe892a0828d70f5cf7eca7
    Closes-Bug: #1514387

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275271

Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

This bug is still fix committed. 275271 is related to bug #1538757

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.