Replace hardcoded strings with consts in fuelmenu
Bug #1514382 reported by
Matthew Mosesohn
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Low
|
Matthew Mosesohn |
Bug Description
We use hardcoded strings in fuelmenu for things like "pre" and "post" deployment modes. This should be located in a consts class and referenced symbolically.
tags: | added: tech-debt |
tags: | added: area-python |
Changed in fuel: | |
status: | New → Confirmed |
Changed in fuel: | |
milestone: | 8.0 → 9.0 |
tags: | added: team-bugfix |
To post a comment you must log in.
From Andrey Tykhonov in https:/ /review. openstack. org/#/c/ 242109: Could you please get rid of these magic (and surplus) constants? Could you please create two methods instead, something like `is_pre_ deployment` , `is_post_ deployment` (and add doc-strings for them)?