update fuel_syntax_checks.sh to leverage the fuel-library rake syntax task

Bug #1513900 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Maksim Malchuk

Bug Description

As part of our integration into openstack-infra CI, we created a syntax task via a Rakefile in fuel-library. The previous Fuel CI implementation of lint and syntax checks were reimplemented as standard rake tasks. We are running the same lint/syntax jobs as openstack-infra CI jobs so we should either remove the fuellib_review_syntax_check job or update the script we currently leverage to use the same method as the openstack-infra jobs.

Artem Roma (aroma-x)
Changed in fuel:
status: New → Confirmed
tags: added: team-bugfix
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Changed in fuel:
milestone: 8.0 → 9.0
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Maksim Malchuk (mmalchuk)
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Would be nice to have this to the 8.0 as well (non release anyway, but improves CI a lot)

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/274286

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jenkins-jobs (master)

Fix proposed to branch: master
Change author: Maksim Malchuk <email address hidden>
Review: https://review.fuel-infra.org/16576

Changed in fuel:
assignee: Maksim Malchuk (mmalchuk) → Dmitry Kaigarodеsev (dkaiharodsev)
Changed in fuel:
assignee: Dmitry Kaigarodеsev (dkaiharodsev) → Maksim Malchuk (mmalchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/274286
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f60d5ed950baefd2223388d66e71b7f037affffd
Submitter: Jenkins
Branch: master

commit f60d5ed950baefd2223388d66e71b7f037affffd
Author: Maksim Malchuk <email address hidden>
Date: Sat Jan 30 00:26:08 2016 +0300

    Rakefile support for Git changes

    This commit enables integration with Git. Now before run
    RSpec or Lint tasks Rakefile will check for Git changes
    and run these tasks on changed modules only otherwise
    they ran against all modules.

    Change-Id: I79ffbb8e2ed0c10cf03a1b2e176b75b314a3e79d
    Closes-Bug: #1537063
    Closes-Bug: #1513900

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/274769

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/8.0)

Change abandoned by Maksim Malchuk (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/274769
Reason: https://review.openstack.org/#/c/274712
should be merged first

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (stable/8.0)

Reviewed: https://review.openstack.org/274769
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4734ab2aec82fa3ccb1aa7a4143f9c3fe11fddaa
Submitter: Jenkins
Branch: stable/8.0

commit 4734ab2aec82fa3ccb1aa7a4143f9c3fe11fddaa
Author: Maksim Malchuk <email address hidden>
Date: Sat Jan 30 00:26:08 2016 +0300

    Rakefile support for Git changes

    This commit enables integration with Git. Now before run
    RSpec or Lint tasks Rakefile will check for Git changes
    and run these tasks on changed modules only otherwise
    they ran against all modules.

    Change-Id: I79ffbb8e2ed0c10cf03a1b2e176b75b314a3e79d
    (cherry picked from commit f60d5ed950baefd2223388d66e71b7f037affffd)
    Closes-Bug: #1537063
    Related-Bug: #1513900

Changed in fuel:
status: Fix Committed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to fuel-infra/jenkins-jobs (master)

Reviewed: https://review.fuel-infra.org/16576
Submitter: Aleksandra Fedorova <email address hidden>
Branch: master

Commit: 513c7a12a0481b4155a8442f7abe17681be3538e
Author: Maksim Malchuk <email address hidden>
Date: Sat Jan 30 21:32:55 2016

Remove fuellib review_syntax_check and unit_tests jobs

Jobs fuellib_review_syntax_check and fuellib_unit_tests
should be removed from stable/8.0 and master because we
already have the same functionality in the upstream
OpenStack jobs.

Change-Id: Ic7ce913a410d1e6379abf02a4eeb9cb197f85ba3
Closes-Bug: #1513900
Related-Bug: #1537063

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.