remove purge openrc logic in keystone task

Bug #1511693 reported by Matthew Mosesohn
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Michael Polenchuk

Bug Description

This is a tech debt bug for cleaning up the modular keystone.pp task that removes /root/openrc before creating the admin user. There should be just a simple relationship between admin user and the openrc (A -> B) so that the admin user is ensured before the /root/openrc file is created. That should remove the need to purge /root/openrc.

Dmitry Klenov (dklenov)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

Class['keystone::roles::admin'] -> Class['openstack::auth_file']
https://github.com/openstack/fuel-library/blob/cf54da03b19c9b3b87cc51cfde519b1ee5428de7/deployment/puppet/osnailyfacter/modular/keystone/keystone.pp#L212-L213

I'm not sure if I get your point, but doesn't that does what you described? Except we still have purge_openrc there.

Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Michael Polenchuk (mpolenchuk)
Revision history for this message
Michael Polenchuk (mpolenchuk) wrote :

We could safely clean exec[purge of openrc] out once got the following related commits merged:
openstacklib => https://review.openstack.org/251477
keystone => https://review.openstack.org/251490

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/251801

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to puppet-modules/puppet-keystone (mos-8.0)

Fix proposed to branch: mos-8.0
Change author: Michael Polenchuk <email address hidden>
Review: https://review.fuel-infra.org/14884

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to puppet-modules/puppet-keystone (mos-8.0)

Reviewed: https://review.fuel-infra.org/14884
Submitter: Denis Egorenko <email address hidden>
Branch: mos-8.0

Commit: cc00ddb8ea3a6a5daeaa6b9b37bc110f0cc5c008
Author: Michael Polenchuk <email address hidden>
Date: Tue Dec 22 08:34:04 2015

Make request by service token if got unauth error

In case then we have openrc before evaluating keystone admin role
the service token auth method should be used instead
of user/password one.

Change-Id: I7b0d87487cb2f4715b6f1255d1e3833c3cd3ea32
Partial-bug: #1511693

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/251801
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a5358a43b62fba26673d11d9b2a9b605822f5891
Submitter: Jenkins
Branch: master

commit a5358a43b62fba26673d11d9b2a9b605822f5891
Author: Michael Polenchuk <email address hidden>
Date: Tue Dec 1 14:13:33 2015 +0300

    Wear off 'purge openrc' exec

    Cleaning up the keystone task that removes /root/openrc
    before creating the admin user.

    Change-Id: Ifb58f06197ed58d3bba62fae8cf99c8ebb2ec025
    Depends-On: Ib922bd5892f0204566656303e6a484daa8d2d5e7
    Depends-On: I7b0d87487cb2f4715b6f1255d1e3833c3cd3ea32
    Closes-Bug: #1511693

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.