fuelmenu contains deprecated ordereddict stuff

Bug #1509464 reported by Artem Silenkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Vladimir Kozhukalov

Bug Description

https://github.com/openstack/fuel-menu/search?utf8=%E2%9C%93&q=OrderedDict

Requires: python-ordereddict should be deleted as OrderedDict is a part of "collection" python core module.

from collections import OrderedDict
should be
from ordereddict import OrderedDict

I'm not sure where to send patch
because of
https://github.com/openstack/fuel-web/search?utf8=%E2%9C%93&q=ordereddict&type=Code

Changed in fuel:
importance: Undecided → High
assignee: nobody → Vladimir Kozhukalov (kozhukalov)
milestone: none → 8.0
Changed in fuel:
status: New → Confirmed
tags: added: module-fuelmenu
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239651

Changed in fuel:
status: Confirmed → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/239651
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=4000f153d99b97cebddda2a27e39ed43c147f306
Submitter: Jenkins
Branch: master

commit 4000f153d99b97cebddda2a27e39ed43c147f306
Author: Vladimir Kozhukalov <email address hidden>
Date: Tue Oct 27 15:19:36 2015 +0300

    Requires python-ordereddict only if Centos6

    OrderedDict class is a part of collections module since at least
    python2.7 which is default python version for Centos 7.
    For making it possible to use this code both on python26
    and on python27 we wrap ordereddict imports into try/except.

    Change-Id: I877506a8f039e86480c287e03387b9a3689d870e
    Closes-Bug: #1509464

Changed in fuel:
status: In Progress → Fix Committed
Vladimir (vushakov)
tags: added: on-verification
Revision history for this message
Vladimir (vushakov) wrote :
Revision history for this message
Vladimir (vushakov) wrote :

Verified on:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "427"
  build_id: "427"
  fuel-nailgun_sha: "9ebbaa0473effafa5adee40270da96acf9c7d58a"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "fae42170a54b98d8e8c8db99b0fbb312633c693c"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "85de57080a18fda18e5325f06eaf654b1b931592"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "e8e36cff332644576d7853c80b8a53d5b955420a"

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.