mysql puppet module doesn't created grants correctly

[Stanislaw Bogatkin]

We use old mysql module that created grants by manually execute sql statements into system table. It results to that fact that such grants don't distribute over cluster nodes.

We need either update our mysql module to upstream version where right way to give grants implemented or change current provider to use standard 'GRANT OPTION' instead of writing to system table.

[Matthew Mosesohn (raytrac3r)]

Sergii, what is the status? It's been in progress and assigned to you for a while.

[Matthew Mosesohn (raytrac3r)]

Currently, no deployments are broken as a result. It is a technical debt and requires some reworking to reintroduce grants correctly

[Sergii Golovatiuk (sgolovatiuk)]

I agree with Matthew. grant tables are not synced between controllers. IT has very specific side effect but it doesn't break a deployment. There are some workarounds how to fix it. Lowering priority to medium i

[Sergii Golovatiuk (sgolovatiuk)]

This issue was resolved by syncing to upstream mysql module (Change-Id: Idd0957c677b87a2d8794e993417ef9e2f0ddf4a6)

Now, I see the same grants on all controllers for all users.

[Alexander Rubtsov (arubtsov)]

Could you please backport the fix to MOS 7.0 ?

[Alexander Rubtsov (arubtsov)]

sla2 for 7.0-updates

[Alexander Rubtsov (arubtsov)]

Please disregard my previous comment - I specified wrong SLA. The correct one is:
sla1 for 7.0-updates

[Dmitry Klenov (dklenov)]

Link to the fix: https://review.openstack.org/#/c/267232/

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 7.0-updates because this change is too risky to be accepted into stable branch:
1. Big and not self-contained change (+705, -6923 LOC), tens of files are changed
2. This is not a bug but substantial refactoring of galera and mysql puppet module.

[Michael Polenchuk (mpolenchuk)]

What about to just update mysql grant provider plus related code that uses it?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/310860

[Dmitry Klenov (dklenov)]

Let's proceed with granular fix for 7.0 for this specific issue.

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 6.1-updates because it requires substantial refactoring of mysql puppet module

[Vitaly Sedelnik (vsedelnik)]

Targeted to 8.0-mu-2 as backport to 8.0 is required before merging backport to 7.0

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/310860
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Vitaly Sedelnik (vsedelnik)]

Removed from 8.0-mu-2 as there is no fix on review

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/333463

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: mos-8.0
Change author: Alexey Stupnikov <email address hidden>
Review: https://review.fuel-infra.org/22512

[Alexey Stupnikov (astupnikov)]

Waiting for MU nomination for 8.0.x series.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/310860
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/333463
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/355884

[Alexey Stupnikov (astupnikov)]

Fix https://review.openstack.org/355884 for MOS 7.0 works well in our lab.

Output: http://pastebin.com/TiR0SXYX

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/355884
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=acce7b7cef569db389826171fc5a9d8b8fdfb4c3
Submitter: Jenkins
Branch: stable/7.0

commit acce7b7cef569db389826171fc5a9d8b8fdfb4c3
Author: Mikhail <email address hidden>
Date: Tue Aug 16 14:48:13 2016 +0300

    Fixed granting of privileges for mysql entities

    In this patch we use 'GRANT PRIVILEGES' command
    instead of writing directly to the table

    Change-Id: Ibde624bc1f35f45d5fab7257dbd81e7e78bdd2f3
    Closes-Bug: #1509069

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/359985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359985
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3e27e0ac8ed8ce67a05c321240358545a6ff5cb2
Submitter: Jenkins
Branch: stable/8.0

commit 3e27e0ac8ed8ce67a05c321240358545a6ff5cb2
Author: Mikhail <email address hidden>
Date: Tue Aug 16 14:48:13 2016 +0300

    Fixed granting of privileges for mysql entities

    In this patch we use 'GRANT PRIVILEGES' command
    instead of writing directly to the table

    Change-Id: Ibde624bc1f35f45d5fab7257dbd81e7e78bdd2f3
    Closes-Bug: #1509069
    (cherry picked from commit acce7b7cef569db389826171fc5a9d8b8fdfb4c3)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/310860
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Ekaterina Shutova (eshutova)]

Verified on MOS 8.0 + mu4 updates.
Privileges are granted for created user https://paste.mirantis.net/show/6292/