errors.CannotUpdate exception doesn't exist

[Alexander Saprykin]

In file nailgun/objects/node.py:447 code

                elif new_cluster_id != instance.cluster_id:
                    # changing node cluster to another
                    # (is currently not allowed)
                    raise errors.CannotUpdate(
                        u"Changing cluster on the fly is not allowed"
                    )

refers to exception that doesn't exist anywhere in the nailgun project.

Need to add this exception to

nailgun/errors/__init__.py

[Aleksey Kasatkin (alekseyk-ru)]

Nailgun version: b09d472543c819bc5b4450f0709a30cc40eb6f7c (10/22/2015)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238457
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6fe73c5d57de5b5950dd388f1721a99a40c6a049
Submitter: Jenkins
Branch: master

commit 6fe73c5d57de5b5950dd388f1721a99a40c6a049
Author: Alexander Saprykin <email address hidden>
Date: Thu Oct 22 13:08:47 2015 +0200

    Add missing CannotUpdate exception

    * Add missing exception CannotUpdate
    * Add unit tests to verify that exception is called

    Closes-Bug: #1508876
    Change-Id: I9b69ac2bb683a01d5c55d11c9df2657ef23da2e8

[Dmitry Belyaninov (dbelyaninov)]

Verified on 361 by unittest

Also I suppose that it is impossible to change cluster_id without unassignment.

[root@nailgun ~]# fuel --env 4 nodes
id | status | name | cluster | ip | mac | roles | pending_roles | online | group_id
---|----------|------------------|---------|------------|-------------------|-------|---------------|--------|---------
11 | discover | Untitled (80:61) | 4 | 10.109.0.4 | 64:9c:69:f4:80:61 | | controller | True | 5
[root@nailgun ~]# fuel --env 5 node set --node 11 --role controller
400 Client Error: Bad Request (Nodes with ids <nailgun.db.sqlalchemy.models.node.Node object at 0x5408190> already assigned to environments. Nodes must be unassigned before they can be assigned again.)

NodeAssignmentValidator error will be raised before "CannotUpdate".