fuel_agent: when label is too long there is an error when creating xfs filesystem

Bug #1505621 reported by Sebastian Kalinowski
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Maciej Kwiek

Bug Description

Labels need to be max 12 chars longs because of mkfs.xfs limitation:

mkfs.xfs -L 12345678901234 /dev/kurnik/kura
Illegal value 12345678901234 for -L option
<snap>

Right now this logic is in driver instead of the code that is responsible for making filesystem (make_fs function). It should be moved there.

Tags: area-python
description: updated
Changed in fuel:
assignee: Sebastian Kalinowski (prmtl) → Fuel Python Team (fuel-python)
status: In Progress → Triaged
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Labels are not used by nailgun at the moment. Changing priority to low.

Changed in fuel:
importance: High → Low
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Maciej Kwiek (maciej-iai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/246883

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/246883
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=b895d7dc49db40fbd9bcc9f1173a327ac66543b9
Submitter: Jenkins
Branch: master

commit b895d7dc49db40fbd9bcc9f1173a327ac66543b9
Author: Maciej Kwiek <email address hidden>
Date: Wed Nov 18 12:05:08 2015 +0100

    Move label formatting to make_fs from driver

    The code that truncated and formatted labels was in driver - too high up
    in code hierarchy. The label is now simply passed to make_fs and it
    handles it properly.

    Change-Id: I87c151e4f01784101977bdd46c3e64401090fc05
    Closes-Bug: #1505621

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

Verified on ISO #567

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "567"
  build_id: "567"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "33634ec27be77ecfb0b56b7e07497ad86d1fdcd3"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.