fuel-master iptables wrong if pxe interface changed from eth0

[Alex Schultz]

If you select to use an interface other than eth0 for the pxe interface on a fuel master node, the iptables rules on the fuel master are not updated to reflect the new interface. Bootstrap nodes may not be able to communicate with mcollective.

[Alex Schultz (alex-schultz)]

Per the docs, the workaround is documented under the PXE setup. But we should automat this.

https://docs.mirantis.com/openstack/fuel/fuel-7.0/user-guide.html#pxe-setup

[Matthew Mosesohn (raytrac3r)]

Reconfiguration after deployment means you need to redeploy everything. This is still and always has been a nailgun limitation, not a cobbler, docker, or puppet one. If you simply change the config in Nailgun settings and restart it, deployments will fail for new and existing environments.

[Dmitry Klenov (dklenov)]

Alex, can you please put more details to the bug description? In particular it is not completely clear if you set different PXE interface from the scratch or after initial node installation.

[Alex Schultz (alex-schultz)]

So i'm just relaying the information provided via IRC. there have been multiple reports of this issue and I assume it's reconfiguring after install. I would say that we need to improve the docs/UX around this. Once a fuel master has been configured once, someone should not be able to change the interface or be provided a giant warning indicating the steps required to fix it.

[Matthew Mosesohn (raytrac3r)]

We can block changing admin interface if there's already 1 deployed environment (in any state besides new).
There are already docs about telling the user the PXE network cannot be changed after deployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/236018

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238604

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/236018
Reason: resubmitted to https://review.openstack.org/238604

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238604
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=c43b5410a87f3b27027076109c28c7a5279420da
Submitter: Jenkins
Branch: master

commit c43b5410a87f3b27027076109c28c7a5279420da
Author: Matthew Mosesohn <email address hidden>
Date: Thu Oct 22 19:24:22 2015 +0300

    Add post-deployment rules for PXE network configuration

    Fuelmenu should allow post-deployment configuration of
    PXE network, but place the following restrictions:
    * new_range must contain old_range in dhcp pool
    * PXE interface must remain the same

    For all intents and purposes, the changes are limited to
    extending the range from the previously configured one.
    A common use case of this would be if a user defined a /24
    network for PXE, and then decided to change it to a /23
    network. This would meet the user's needs and not impact
    existing deployed nodes.

    Change-Id: I42fc5d3261fe7e6c4a996e9895710970fc721247
    Closes-Bug: #1503828

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #567
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "567"
  build_id: "567"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "33634ec27be77ecfb0b56b7e07497ad86d1fdcd3"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

It it impossible:
to decrease DHCP range -> Errors: DHCP range can only be increased after deployment.
to change PXE interface -> Errors: Cannot change admin interface after deployment.