[liberty] deployment fails at upload_cirros.rb step

[Atsuko Ito]

Deployment fails with "Deployment has failed. Method granular_deploy. Failed to execute hook 'shell' Failed to run command cd / && ruby /etc/puppet/modules/osnailyfacter/modular/astute/upload_cirros.rb"

On Liberty, python-glanceclient is using V2 interface by default. Need to fall back to v1.

--- /etc/puppet/modules/osnailyfacter/modular/astute/upload_cirros.rb 2015-10-07 16:57:24.000000000 +0000
+++ upload_cirros.rb 2015-10-07 16:58:20.614186778 +0000
@@ -53,7 +53,7 @@

 def image_create(image_hash)
   command = <<-EOF
-/usr/bin/glance --os-image-api-version 1 image-create \
+/usr/bin/glance image-create \
 --name '#{image_hash['img_name']}' \
 --is-public '#{image_hash['public']}' \
 --container-format='#{image_hash['container_format']}' \

Also, there is no admin role for user glance in admin tenant.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "129"
  build_id: "129"
  fuel-nailgun_sha: "a95a1c14595c4ed0dd32a491009cf7bb9641b4e0"
  python-fuelclient_sha: "8cc852ffe19d393f4b529cf8bad5b70a68014a66"
  fuel-agent_sha: "e881f0dabd09af4be4f3e22768b02fe76278e20e"
  fuel-nailgun-agent_sha: "d66f188a1832a9c23b04884a14ef00fc5605ec6d"
  astute_sha: "0f753467a3f16e4d46e7e9f1979905fb178e4d5b"
  fuel-library_sha: "e3d2905b9dd2cc7b4d46201ca9816dd320868917"
  fuel-ostf_sha: "41aa5059243cbb25d7a80b97f8e1060a502b99dd"
  fuel-createmirror_sha: "df6a93f7e2819d3dfa600052b0f901d9594eb0db"
  fuelmain_sha: "f208d8963624ea9cd7810a20258fc6f5a44a33c3"

[Denis Egorenko (degorenko)]

Error occurs because of using '--is-public' option for v2 glance-api. As another way, we can use proper option: --visibility {public,private}

[1] http://docs.openstack.org/cli-reference/content/glanceclient_commands.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/232486

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232488

[OpenStack Infra (hudson-openstack)]

Change abandoned by Denis Egorenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/232486
Reason: Abandon this change in favor of: https://review.openstack.org/232488

This change affects env upgrading from 7.0 to 8.0.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232488
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d1567417eac9a8f1dc3196dfb0c08f13ec1a7427
Submitter: Jenkins
Branch: master

commit d1567417eac9a8f1dc3196dfb0c08f13ec1a7427
Author: Denis Egorenko <email address hidden>
Date: Thu Oct 8 14:45:00 2015 +0300

    Specify explicitly Glance API v1 for uploading cirros image.

    Since liberty glance client uses v2 glance-api version and there is
    no such property 'is-public'. So specify explicitly v1 API version
    (to keep backward compatibility with Fuel 7.0).

    Change-Id: Idf589a352edda398e8614b23f5352daa432b0887
    Closes-bug: #1503790

[Tatyanka (tatyana-leontovich)]

verified
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "466"
  build_id: "466"
  fuel-nailgun_sha: "f81311bbd6fee2665e3f96dcac55f72889b2f38c"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "6823f1d4005a634b8436109ab741a2194e2d32e0"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "fe03d887361eb80232e9914eae5b8d54304df781"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "fac143f4dfa75785758e72afbdc029693e94ff2b"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "727f7076f04cb0caccc9f305b149a2b5b5c2af3a"