Cannot specify custom iptables rules for VIP in network role

[Andrey Shestakov]

When custom network role defined with VIP
Is not possible to specify custom firewall rules for that VIP in namespace

I see needed parameters are hardcoded:
https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/osnailyfacter/lib/puppet/parser/functions/generate_vips.rb#L100

[Dmitry Klenov (dklenov)]

Andrey, can you please specify:
* Detailed steps to reproduce.
* At which step(s) you see the discrepancy with expected results.

[Sergey Vasilenko (xenolog)]

For unhardcode this parameters from generate_vip function, I propose move it to VIP declaration yaml.

For this we should add hash, that will not parsed by nailgun and will be passed to astute.yaml as is.
I.e VIP declaration may be look following:

    vip:
       - name: "baremetal"
         namespace: "haproxy"
         node_roles: [.......]
         vendor_specific:
             firewall_start: rule1
             firewall_stop: rule2

This 'vendor_specific' field may be used for transfer all plugin-specific information to puppet manifests.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243045
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1fd1ca52b3c4abee2cd40a4e8eb463867209278f
Submitter: Jenkins
Branch: master

commit 1fd1ca52b3c4abee2cd40a4e8eb463867209278f
Author: Andrey Shestakov <email address hidden>
Date: Fri Nov 13 16:25:13 2015 +0200

    Add vendor_specific parameter to VIPs meta

    This parameter allows specify plugin specific informaton in VIPs
    declaration.
    Add default iptables rules for vrouter_pub VIP

    DocImpact:
    Change-Id: I4fce3411d36f6d9e6257230f76178fd39ffd70c2
    Partial-bug: #1502922