We need a script which will, on every patch uploaded to Gerrit, add reviewers automatically based on data in MAINTAINERS file(s).
Please see following two patches with introduction of MAINTAINERS files, and follow links provided in commit messages for further details.
https://review.openstack.org/#/c/225457/1 - top-level repo file
https://review.openstack.org/#/c/225458/1 - fuelmenu subfolder
Example:
commit is made to fuel-web/fuelmenu/fuelmenu/modules/interfaces.py, and fuel-web/fuelmenu/fuelmenu/common/errors.py.
Script has to search for MAINTAINERS file in all folders, starting from the folder where files were changed.
The logic should be the following:
- if there is a MAINTAINERS file in fuel-web/fuelmenu/fuelmenu/modules/, add reviewers from 'maintainers' section of the file to the review. Same for another file.
- if there is no MAINTAINERS file fuel-web/fuelmenu/fuelmenu/modules/, go level up and check there.
- continue going up if needed. Do nothing, if file not found or there is no 'maintainers' section in the file.
Two notes:
- there are can be MAINTAINERS files on a few levels of hierarchy. We need to take maintainers only from one file, which is found first (do not collect all). We want only specific subject matters to be added if those defined, not core reviewers / maintainers of the whole module
- if several files are touched by commit, ensure to check MAINTAINERS file for each separately (don't stop on first file). We want to find all subject matter experts.
MAINTAINERS in different reviews has different format.
I think that MAINTAINERS on top level will have list with dict of repo:
On top level:
{ 'maintainers':
[{'fuelmenu/':
[{'IRC': 'mattymo',
'email': '<email address hidden>',
'name': 'Matthew Mosesohn'},
{'IRC': 'mattymo',
'email': '<email address hidden>',
'name': 'Matthew Mosesohn'}],
},
{'docs/':
[{'IRC': 'mattymo',
'email': '<email address hidden>',
'name': 'Matthew Mosesohn'},
{ 'email': '<email address hidden>',
'name': 'User2'}],
}]}
In subfolders:
{'maintainers': [{
'IRC': 'mattymo',
'email': '<email address hidden>',
'name': 'Matthew Mosesohn'
},
{
'email': '<email address hidden>',
'name': 'User2'
}]}