Network configuration handlers should return object not task

Bug #1496630 reported by Aleksey Kasatkin on 2015-09-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
Vitaly Kramskikh
7.0.x
Medium
Fuel Python (Deprecated)

Bug Description

Versions: 7.0 and prior.

As for now, network configuration handlers (/clusters/<cluster_id>/network_configuration/neutron/ and /clusters/<cluster_id>/network_configuration/nova_network/) return task objects not network configuration objects. They also return error in those task objects when check_networks or update_network failed while status code for API request remains 200.

Using of tasks in these handlers is not required actually, also they should return actual object instead of task (especially since the task is completed already) and actual request result codes.

Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov) on 2015-09-18
tags: added: tech-debt
Changed in fuel:
importance: High → Medium
tags: added: customer-found
Aleksey Kasatkin (alekseyk-ru) wrote :

These are NeutronNetworkConfigurationHandler and NovaNetworkConfigurationHandler handlers (PUT methods) which should be fixed. CheckNetworks there can be called without creation of Nailgun task. Also, actual networking configuration should be returned.

Changed in fuel:
status: Confirmed → Triaged
Aleksey Kasatkin (alekseyk-ru) wrote :

Correction: class name is NetworkCheck not CheckNetworks.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Alexander Saprykin (cutwater)
Aleksey Kasatkin (alekseyk-ru) wrote :

UI/CLI should be changed accordingly.

Changed in fuel:
status: Triaged → In Progress
Changed in fuel:
assignee: Alexander Saprykin (cutwater) → Vitaly Kramskikh (vkramskikh)
Changed in fuel:
assignee: Vitaly Kramskikh (vkramskikh) → Alexander Saprykin (cutwater)
Changed in fuel:
assignee: Alexander Saprykin (cutwater) → Vitaly Kramskikh (vkramskikh)

Reviewed: https://review.openstack.org/232021
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c87470bf9c4fbd622ff443a786b96d8c2dc619b9
Submitter: Jenkins
Branch: master

commit c87470bf9c4fbd622ff443a786b96d8c2dc619b9
Author: Alexander Saprykin <email address hidden>
Date: Wed Oct 7 17:03:53 2015 +0300

    Network configuration handlers return network config

    Change-Id: I6dc259813418de5df4b9fb97f65066b130348b21
    Closes-Bug: #1496630

Changed in fuel:
status: In Progress → Fix Committed
Sebastian Kalinowski (prmtl) wrote :
Changed in fuel:
status: Fix Committed → Confirmed
Dmitry Pyzhov (dpyzhov) on 2015-10-22
tags: added: area-ui
Changed in fuel:
status: Confirmed → Fix Committed
tags: added: wontfix-low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers