[8.0-pkg-pipeline-ubuntu] Remove 'nocheck' option from DEB_BUILD_OPTIONS

[Ivan Udovichenko]

Unit tests run is required during package build.

We should get rid of 'nocheck' option in DEB_BUILD_OPTIONS variable and not use it by default.

[Roman Vyalov (r0mikiam)]

related to the non openstack packages

[Vladimir Kozhukalov (kozhukalov)]

This issue can not be easily fixed in the near future. The reason for this is that package build environment is not suitable for running the majority of unit tests (for details, please ask Dmitry Burmistrov). For OpenStack and for Fuel we run unit tests using separate jobs. Besides, it is common practice even in upstream to skip running unit tests if they fail. Let's think of using dedicated unit test jobs for the rest of projects for which we re-build packages. So, changing status to Won't fix.

[Alexander Tsamutali (astsmtl)]

Usually unit testing doesn't require and specific environment, so chroot or docker container should be enough (provide explanation of you disagree). What we want is a possibility to enable/disable unit testing during package building process at our discretion.

[Ivan Udovichenko (iudovichenko)]

Hello Vladimir,
I strongly disagree with you. If unit tests fails, go and fix it. During build all required packages are being installed, so unit tests should be able to run. Could you please name "it is common practice even in upstream to skip running unit tests if they fail" about what upstream are you talking about ? Could you please explain in details what are the "dedicated unit test jobs for the rest of projects for which we re-build packages" ? I guess that it is obvious that we NEED the run of unit tests during build of package, not as a separate job, etc. I hope you get the idea.

[Vladimir Kozhukalov (kozhukalov)]

> dedicated unit test jobs for the rest of projects for which we re-build packages
That means not openstack and not fuel packages. Both for Openstack and for Fuel we run unit tests as separate jobs. For Fuel unit tests are runned as merge gating. That means all commits in Fuel projects successfully passed tests. The same is suggested for the rest of projects. We can run unit tests for them separately preparing suitable env.

> it is common practice even in upstream to skip running unit tests if they fail
Of course, I mean those tests that can not be run or fail due to environment related issues (not application logic). Unfortunately, the majority of unit test sets in the real world are not, in fact, unit. In many cases they need some services to be run, they just don't mock application interfaces. For example Fuel UI tests need Nailgun running.

I'm totally for running as many tests as we need and even more. But according to the information that I've got from D. Burmistrov, we just can not implement an easy way for preparing unit test envs in terms of Perestroika in the near future. It can lead to the situation when a package fails to be built just due to wrong env. That can bring other build team activities under the risk because we will fight env issues.

I'm just suggesting to re-think the issue in term of running unit tests as separate jobs or at least to postpone the issue until we are ready (we have plans to make Perestroika much more maintainable and easy to use).

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: feature/new-build-system
Change author: Dmitry Burmistrov <email address hidden>
Review: https://review.fuel-infra.org/12089

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Dmitry Burmistrov <email address hidden>
Review: https://review.fuel-infra.org/12092

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/12200
Submitter: Sergey Kulanov <email address hidden>
Branch: master

Commit: aee01c7fe33337579c08b856b4651154e7fcbe5c
Author: Alexander Evseev <email address hidden>
Date: Tue Sep 29 09:29:18 2015

Add parameters to disable unittests for merged changes

Related-Bug: #1495411

Change-Id: I64ac29f5151d62a978de512f2259fb1b7de8b3ed

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Alexander Evseev <email address hidden>
Review: https://review.fuel-infra.org/12262

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/12262
Submitter: Sergey Kulanov <email address hidden>
Branch: master

Commit: 6669c304baaff9c711c39a50bfab18ccc58acae8
Author: Alexander Evseev <email address hidden>
Date: Tue Sep 29 13:42:58 2015

Disable unittests for merged changes to Fuel packages

Change-Id: I961430e8782ddffb8638eb2e94064aa6ebaea9c4
Related-Bug: #1495411

[Timur Nurlygayanov (tnurlygayanov)]

Ok, it looks like all works fine, moved to Fix Released.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Dmitry Burmistrov <email address hidden> on branch: master
Review: https://review.fuel-infra.org/12092

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Dmitry Burmistrov <email address hidden> on branch: feature/new-build-system
Review: https://review.fuel-infra.org/12089