[8.0-pkg-pipeline-ubuntu][OS components] Build should fail in case of different versions in changelog and last tag

[Ivan Udovichenko]

Build should fail if provided version in debian/changelog and last tag in OpenStack component code differs significantly.

[Dmitry Burmistrov (dburmistrov)]

Please formalize conditions to failure.

[Ivan Udovichenko (iudovichenko)]

For example: 2015.2 and 7.0.0 versions differ, in this case build job should fail.
7.0.0 and 7.0.1 versions differ and the job should fail.
You can check the version in Debian for example, how the tag and version differ.

[Dmitry Burmistrov (dburmistrov)]

According to change-request comment
>Also at this moment only 3 digits is a good idea to use.
>For example 7.0.0.0b3, only 7.0.0 is a good idea to use and compare to package version.
please formalize conditions
All tag list for each openstack project you can find at review.openstack.org
Example for nova project: https://review.openstack.org/gitweb?p=openstack/nova.git;a=tags

[Ivan Udovichenko (iudovichenko)]

Compare first 3 digits:
x.x.x

[Dmitry Burmistrov (dburmistrov)]

Not all tags match template "x.x.x". Please describe rules for all available tag formats.

[Roman Vyalov (r0mikiam)]

i think we can add additional test in our packaging ci for this issue. but we need clear description for this task. At the moment openstack package version automatically generated from gerrit tag and CI add information about version to the package changelog. because of this we need more information why and how we can implement this test ?

[Ivan Udovichenko (iudovichenko)]

Take only tags with numbers and ignore other cases. Please put some time in finding the best solution as you have far more experience in maintaining build systems in our company and know all its bottlenecks.
Thank you for your time and great work.

[Vladimir Kozhukalov (kozhukalov)]

Until there is clear requirement for the issue, it is incomplete. Ivan, please give formal criteria. Probably that is more CI related issue rather than build related one. So changing to Incomplete (AGAIN) and re-assigning to fuel-ci.

[Ivan Udovichenko (iudovichenko)]

Hello Vladimir,
What other criteria do you need ? It ment to be a simple check.
Follow the pattern and ignore all other cases.
It will prevent from sudden changes to the code.
I'd be glad if you share your concerns in details.

[Aleksandra Fedorova (bookwar)]

This test should be part of build scripts, not a separate CI job.

Build team please check if you can implement it

[Dmitry Burmistrov (dburmistrov)]

IMO this activity doesn't related neither build nor install test stage. It shoul be separate CI check started before build stage

[Alexander Tsamutali (astsmtl)]

Our requirements are simple. As Roman said build system infers version from source code and updates spec/debian with this version. Instead of updating, please check if spec/debian _already contains_ inferred version. If not - fail build.

[Ivan Udovichenko (iudovichenko)]

Increasing the bug priority due to related issues: https://bugs.launchpad.net/fuel/+bug/1565630

[Alexey Golubev (agolubev)]

Bug priority should be reverted to Medium, due to invalidity of the issue, mentioned above (https://bugs.launchpad.net/fuel/+bug/1565630)

[Ivan Udovichenko (iudovichenko)]

The bug itself is valid, the chaos was proposed by this commit https://review.fuel-infra.org/18558/ as Dmitry B. found out. And CI automatically generated the latest version from tag. That is why I've raised the priority.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301730

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/301730
Committed: https://git.openstack.org/cgit/openstack/fuel-mirror/commit/?id=fb1850062a4c1ed7a01c3eef7190104109df5f73
Submitter: Jenkins
Branch: master

commit fb1850062a4c1ed7a01c3eef7190104109df5f73
Author: Alexey Golubev <email address hidden>
Date: Tue Apr 5 17:42:28 2016 +0300

    Added version comparison from gerrit tag and changelog

    Build fails if provided version in spec file and the
    last tag in OpenStack component code differs.

    Change-Id: I7e15692c2aacbdde13dea86eae954cb9665e3828
    Closes-Bug: #1495406

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Dmitry Burmistrov <email address hidden> on branch: feature/new-build-system
Review: https://review.fuel-infra.org/11557