Verification of particular networks is skipped in some cases

[Aleksey Kasatkin]

Applies to network templates only.
Problem with verification of networks https://bugs.launchpad.net/fuel/+bug/1492947 was fixed in https://review.openstack.org/#/c/221027/ so that networks defined in particular template are excluded from verification when that template is in use for one node of environment only.
The purpose of that is to exclude from verification the networks which are in use for one node of environment only.

But different templates can define the same networks, e.g. 'storage_for_compute' and 'storage_or_controller' templates define the same network for different roles. These templates (and corresponding networks) will be excluded from verification if each of these templates is in use for one node only. But the networks which are defined in the templates are in use for more than one node because they define the same networks. So, the fix mentioned above may exclude networks from verification even if they should not be excluded.

This should be fixed to not exclude from verification the networks which could be verified.

[Aleksey Kasatkin (alekseyk-ru)]

Now, to make net-checker working properly, we need to exclude from testing the networks which are set up on one node (in particular environment) only. So, the fix from description excludes networks from testing when they are defined in template which is in use on one node only. So, if a template is in use on one node only it (with all its networks) is excluded from testing.

But different templates can define the same networks. E.g. template 'common1' is in use on node1 only and it uses networks 'management' and 'private'. E.g. template 'common2' is in use on node2 only and it uses networks 'management' and 'storage'. So, with the current solution (the fix from description) will exclude both template 'common1' and 'common2' from testing. So, 'management' network will not be tested on those nodes but it could be tested as it is in use on more than one node.

Proper fix should look inside the templates which are in use on nodes and filter by networks not by names of the templates.

[Alexander Kislitsky (akislitsky)]

We passed SCF in 8.0. Moving the bug to 9.0.