Activity log for bug #1494320

Date Who What changed Old value New value Message
2015-09-10 13:11:36 Alexander Bochkarev bug added bug
2015-09-10 13:12:03 Alexander Bochkarev fuel: assignee Fuel Python Team (fuel-python)
2015-09-10 13:12:37 Alexander Bochkarev description Internal server error happens when an incorrect/missing 'cluster_id' value is passed in the request body, for example: '{"cluster_id": 100, "name":"cluster"}'. Traceback: { "message": "Traceback (most recent call last):\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/handlers/base.py\", line 166, in checked_data\n valid_data = method(data, **kwargs)\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/validators/node_group.py\", line 32, in validate\n if cluster.net_provider == consts.CLUSTER_NET_PROVIDERS.nova_network:\nAttributeError: 'NoneType' object has no attribute 'net_provider'\n", "errors": [] } I suppose that NodeGroupValidator must be strengthened by checking on absence of a cluster. Also must be provided some error message which will inform about that. Internal server error happens when an incorrect/missing 'cluster_id' value is passed in the request body, for example: '{"cluster_id": 100, "name":"cluster"}'. Traceback: {     "message": "Traceback (most recent call last):\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/handlers/base.py\", line 166, in checked_data\n valid_data = method(data, **kwargs)\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/validators/node_group.py\", line 32, in validate\n if cluster.net_provider == consts.CLUSTER_NET_PROVIDERS.nova_network:\nAttributeError: 'NoneType' object has no attribute 'net_provider'\n",     "errors": [] } I suppose that NodeGroupValidator must be strengthened by checking on absence of a cluster. Also must be provided some error message which will inform about that.
2015-09-10 14:09:35 deactivateduser fuel: status New Incomplete
2015-09-10 14:09:38 deactivateduser fuel: importance Undecided High
2015-09-10 14:10:01 deactivateduser fuel: milestone 8.0
2015-09-10 14:12:03 deactivateduser nominated for series fuel/7.0.x
2015-09-10 14:12:03 deactivateduser bug task added fuel/7.0.x
2015-09-10 14:12:20 deactivateduser fuel/7.0.x: assignee Fuel Python Team (fuel-python)
2015-09-10 14:12:22 deactivateduser fuel/7.0.x: importance Undecided High
2015-09-10 14:12:26 deactivateduser fuel/7.0.x: status New Incomplete
2015-09-10 14:18:10 deactivateduser fuel/7.0.x: milestone 7.0
2015-09-10 16:29:14 Alexander Bochkarev description Internal server error happens when an incorrect/missing 'cluster_id' value is passed in the request body, for example: '{"cluster_id": 100, "name":"cluster"}'. Traceback: {     "message": "Traceback (most recent call last):\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/handlers/base.py\", line 166, in checked_data\n valid_data = method(data, **kwargs)\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/validators/node_group.py\", line 32, in validate\n if cluster.net_provider == consts.CLUSTER_NET_PROVIDERS.nova_network:\nAttributeError: 'NoneType' object has no attribute 'net_provider'\n",     "errors": [] } I suppose that NodeGroupValidator must be strengthened by checking on absence of a cluster. Also must be provided some error message which will inform about that. To reproduce this bug in dev environment is required to perform the following curl request (don't forget to put the correct token): curl 'http://127.0.0.1:8000/api/nodegroups/' -X POST -H 'Accept: application/json' -H 'Cookie: i18next=en-US; token=token1441899446' --data '{"cluster_id":100,"name":"cluster"}' Please see traceback: { "message": "Traceback (most recent call last):\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/handlers/base.py\", line 166, in checked_data\n valid_data = method(data, **kwargs)\n File \"/usr/lib/python2.6/site-packages/nailgun/api/v1/validators/node_group.py\", line 32, in validate\n if cluster.net_provider == consts.CLUSTER_NET_PROVIDERS.nova_network:\nAttributeError: 'NoneType' object has no attribute 'net_provider'\n", "errors": [] } Internal server error happens when an incorrect 'cluster_id' value is passed in the request body. In our case the incorrect cluster id is 100. I suppose that NodeGroupValidator must be strengthened by checking on absence of a cluster. Also must be provided some error message which will inform about that. Link to the block of code: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/api/v1/validators/node_group.py#L31-L35
2015-09-10 16:29:50 Alexander Bochkarev fuel/7.0.x: status Incomplete New
2015-09-10 16:29:57 Alexander Bochkarev fuel: status Incomplete New
2015-09-11 07:33:35 deactivateduser fuel: status New Confirmed
2015-09-11 07:33:38 deactivateduser fuel/7.0.x: status New Confirmed
2015-09-11 07:41:25 deactivateduser fuel/7.0.x: status Confirmed Won't Fix
2015-09-18 10:15:28 Ihor Kalnytskyi fuel: assignee Fuel Python Team (fuel-python) Igor Kalnitsky (ikalnitsky)
2015-09-18 15:19:40 OpenStack Infra fuel: status Confirmed In Progress
2015-09-21 09:16:31 Ihor Kalnytskyi nominated for series fuel/8.0.x
2015-09-21 09:16:31 Ihor Kalnytskyi bug task added fuel/8.0.x
2015-09-21 10:01:36 OpenStack Infra fuel: status In Progress Fix Committed
2015-10-06 14:46:12 Dmitry Pyzhov fuel/7.0.x: milestone 7.0 7.0-updates
2015-10-06 14:46:15 Dmitry Pyzhov fuel/7.0.x: status Won't Fix Confirmed
2015-10-06 14:46:23 Dmitry Pyzhov bug task deleted fuel/8.0.x
2015-10-08 09:28:54 Sergey Novikov tags module-nailgun module-nailgun on-verification
2015-10-08 11:39:51 Vitaly Sedelnik fuel/7.0.x: assignee Fuel Python Team (fuel-python) Igor Kalnitsky (ikalnitsky)
2015-10-08 11:39:55 Vitaly Sedelnik fuel/7.0.x: milestone 7.0-updates 7.0-mu-1
2015-10-09 09:25:45 Sergey Novikov fuel: status Fix Committed Fix Released
2015-10-09 09:26:21 Sergey Novikov tags module-nailgun on-verification module-nailgun
2015-10-09 10:44:53 Dmitry Pyzhov fuel/7.0.x: status Confirmed Fix Committed
2015-10-16 13:28:50 Dmitriy Kruglov tags module-nailgun module-nailgun on-verification
2015-10-16 15:31:17 Dmitriy Kruglov fuel/7.0.x: status Fix Committed Fix Released
2015-10-16 15:31:28 Dmitriy Kruglov tags module-nailgun on-verification module-nailgun
2015-10-22 03:09:47 Dmitry Pyzhov tags module-nailgun area-python module-nailgun