error in validation global symbol '*' in deployment_tasks.yaml

[Maciej Relewicz]

code in deployment_task.yaml (compatible with documentation):

- id: zabbix-plugin-deploy-agents
  type: puppet
  role: '*'
  requires: [post_deployment_start]
  required_for: [post_deployment_end]
  parameters:
    puppet_manifest: puppet/manifests/agent.pp
    puppet_modules: puppet/modules:/etc/puppet/modules
    timeout: 600

generate validation error in fpb 2.0.5-dev0

$ fpb --check ./
Validation failed
File './deployment_tasks.yaml', '*' is not of type 'array', value path '3 -> role'

[Ihor Kalnytskyi (ikalnytskyi)]

Looks we don't support

  role: '*'

for pre/post deployment tasks in fpb's validator.

[Andriy Popovych (popovych-andrey)]

Yes, but more intuitively for me

role: ['*'] . Because role has type of list.

[Maciej Relewicz (rlu)]

code:

- id: zabbix-plugin-deploy-agents
  type: puppet
  role: ['*']
  requires: [post_deployment_start]
  required_for: [post_deployment_end]
  parameters:
    puppet_manifest: puppet/manifests/agent.pp
    puppet_modules: puppet/modules:/etc/puppet/modules
    timeout: 600

produce:
Validation failed
File './deployment_tasks.yaml', '*' does not match '^[0-9a-zA-Z_-]+$', value path '3 -> role -> 0'

the problem is that fpb is expecting alphabetic or numeric character in role parameter

[Alexander Kislitsky (akislitsky)]

@Andriy, * is the special case. If we use ['*'] notation, then we will have roles list like ['a', 'b', '*', 'c'].

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220447

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220447
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=bffcc793b0f04b533323ad07a57b208acbdaea12
Submitter: Jenkins
Branch: master

commit bffcc793b0f04b533323ad07a57b208acbdaea12
Author: Alexander Kislitsky <email address hidden>
Date: Fri Sep 4 13:22:41 2015 +0300

    Role * supported for deployment tasks

    JSON schema for role changed. We support '*' or list
    of tasks names in role field.
    Duplication of test 'test_check_group_type_deployment_task' removed.

    Change-Id: I32321826e5e8b45ea0e5d6cc2e1361fba9cbce14
    Closes-Bug: #1492167

[Liubov Efremova (lefremova)]

Verified on: fuel-7.0-286-2015-09-07_03-14-53.iso

[Alexander Adamov (aadamov)]

The appropriate note was added to https://wiki.openstack.org/wiki/Fuel/Plugins#Configuration_of_Fuel_Plugins_with_new_roles.