If unkown version of Ceph is used, assert exception is raised

Bug #1488883 reported by Evgeniy L
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Fuel Sustaining
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Newton
Confirmed
Medium
Fuel Sustaining

Bug Description

If there is unknown Ceph release is used, UnkownCephRelease exception should be used instead of gneral Assert exception, so on higher level it's possible to handle specifically this error, without catching all assert exceptions.

https://review.openstack.org/#/c/204814/21/nailgun/nailgun/utils/ceph.py

Revision history for this message
Alexander Kislitsky (akislitsky) wrote :

Also get_pool_pg_count can be refactored to set of small functions. It could improve code readability and tests coverage.

Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Revision history for this message
Kostiantyn Danylov (kdanylov) wrote :

Whole this ticket is a nice example of WAT.
View, please, https://www.youtube.com/watch?v=o9pEzgHorH0.
There absolutely no reason for new exception class. AssertionError mean, that something really bad with
internal logic. It should be logged and converted into 5XX code

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We passed SCF in 8.0. Moving the bug to 9.0.

Changed in fuel:
milestone: 8.0 → 9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.