[VIPs] VIP name and namespace should be normalized

Bug #1487007 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Kseniya Tychkova

Bug Description

VIPs can be requested via plugins metadata in 7.0.
While VIPs data is serialized for orchestrator name and namespace of VIP should match the following requirements:
it may consist of lowercase latin letters, numbers, '-' and '_'.
All other symbols should be converted to '_'.

Revision history for this message
Evgeniy L (rustyrobot) wrote :

>> All other symbols should be converted to '_'.

Are you sure about convertation? Shouldn't they be rejected?

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Kseniya Tychkova (ktychkova)
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Yeah, I agree with Evgenyy here. We should reject it instead of implicit changes.

BTW, do we have such validation in fpb ?

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

I'm Okay to reject that if we have good mechanism for doing that. (At plugin development stage or at plugin loading stage).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215219

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/215219
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=c30c74c11458bcbbdf35516acb2769c8d16400d3
Submitter: Jenkins
Branch: master

commit c30c74c11458bcbbdf35516acb2769c8d16400d3
Author: Kseniya Tychkova <email address hidden>
Date: Thu Aug 20 19:14:05 2015 +0300

    VIP name and namespace should be normalized

    name and namespace of VIP should match the following requirements:
    it may consist of lowercase latin letters, numbers, '-' and '_'

    Change-Id: Ib01ef8064d6c49b9428a97b2b95a9f13821c3c9c
    Closes-Bug: #1487007

Changed in fuel:
status: In Progress → Fix Committed
tags: added: module-railgun on-verification
removed: module-nailgun
tags: added: module-nailgun
removed: module-railgun
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

Verified for the master branch of fuel-plugins repo at Aug 28, 2015

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.