Unused schema in nailgun objects adding to technical debt of code

[Przemyslaw Kaminski]

We have a 'schema' dict in NailgunObject https://github.com/stackforge/fuel-web/blob/stable/6.1/nailgun/nailgun/objects/base.py#L56-L58 which is used only in the NailgunObject.check_field method (https://github.com/stackforge/fuel-web/blob/stable/6.1/nailgun/nailgun/objects/base.py#L60-L74) which in turn is used only in NailgunCollection.filter_by (https://github.com/stackforge/fuel-web/blob/stable/6.1/nailgun/nailgun/objects/base.py#L261-L287) and NailgunCollection.filter_by_not (https://github.com/stackforge/fuel-web/blob/stable/6.1/nailgun/nailgun/objects/base.py#L289-L314). The only class with schema implemented is NodeGroups (https://github.com/stackforge/fuel-web/blob/stable/6.1/nailgun/nailgun/objects/node_group.py#L28-L43). I suggest to remove all of this code -- writer of filter_by queries should know what fields to filter by, it doesn't have to be automatically checked, especially that SQLAlchemy does such checks already. Removing all of it will reduce technical debt of the code (and schema from NodeGroups.schema can be moved to api/v1/validators/json_schema).

[Dmitry Pyzhov (dpyzhov)]

We passed SCF in 8.0. Moving the bug to 9.0.