Do not get parser directly from ShowOne in fuel2 client

Bug #1482515 reported by Sebastian Kalinowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Fuel Sustaining
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Newton
Confirmed
Medium
Fuel Sustaining

Bug Description

BaseShowCommand in fuel2 commands has a default parser that seems not to be useful. In few commands that inherits from it, the parser gets overwritten and the params added in BaseShowCommand are removed in favor to the one from original cliff ShowOne command.

Let's add a method called like "get_base_parser" that will be a helper to get the "raw" parser from ShowOne class instead of doing it by hand in those places:

https://github.com/stackforge/python-fuelclient/blob/55bd33a15875bfbe0790f9d48c8f7697312b822a/fuelclient/commands/environment.py#L57-L58
https://github.com/stackforge/python-fuelclient/blob/55bd33a15875bfbe0790f9d48c8f7697312b822a/fuelclient/commands/environment.py#L140-L141

There are also incoming reviews where the same thing is happening, like this one:
https://review.openstack.org/#/c/207398/14/fuelclient/commands/network_group.py (line 93, line 130)

Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 8.0
tags: added: tech-debt
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We passed SCF in 8.0. Moving the bug to 9.0.

Changed in fuel:
milestone: 8.0 → 9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.