Fuel for OpenStack

Make dockerfiles more readable

Bug #1482232 reported by Matthew Mosesohn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Matthew Mosesohn
Fuel for OpenStack 8.0

Bug Description

Our dockerfiles have very long RUN commands. It's good to keep long RUN commands with multiple commands to create less docker layers, but they can be broken up into multiline format, such as:

RUN echo 'All of your\n\
multiline that you ever wanted\n\
into a dockerfile\n'\
>> /etc/example.conf

Matthew Mosesohn (raytrac3r)
Changed in fuel:
milestone: none → 8.0
assignee: nobody → Matthew Mosesohn (raytrac3r)
importance: Undecided → Medium
status: New → Triaged
Matthew Mosesohn (raytrac3r)
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225665

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/225665
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=16eac32808bcb0429923a1e82a2460c073080955
Submitter: Jenkins
Branch: master

commit 16eac32808bcb0429923a1e82a2460c073080955
Author: Matthew Mosesohn <email address hidden>
Date: Mon Sep 21 16:15:03 2015 +0300

    Improve readability of dockerfiles and cleanup

    * Added newlines to long RUN commands in dockerfiles.
    * Removed storage-* containers (obsolete since 6.0)
    * Removed shotgun workaround in mcollective container.
    * Cleaned up duplicate packages already included in
      fuel/centos base container.
    * Moved hiera default yaml workaround to fuel/centos

    Change-Id: I1ed33c6df5a5dcac2c0861e08d36184d9a8c2c2d
    Closes-Bug: #1482232

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Fix reverted because of bug #1502780

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

I will investigate locally with the following ISO with the bad commit: https://product-ci.infra.mirantis.net/job/8.0-kilo.all/120/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234174

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/234174
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=b4ee14a25d277c46cc5b1ed7be46b4f5b28a1163
Submitter: Jenkins
Branch: master

commit b4ee14a25d277c46cc5b1ed7be46b4f5b28a1163
Author: Matthew Mosesohn <email address hidden>
Date: Tue Oct 13 12:12:19 2015 +0000

    Improve readability of dockerfiles and cleanup

    * Added newlines to long RUN commands in dockerfiles.
    * Removed storage-* containers (obsolete since 6.0)
    * Removed shotgun workaround in mcollective container.
    * Change disable of mcollective service in start.sh,
      rather than blocking init script in Dockerfile
    * Cleaned up duplicate packages already included in
      fuel/centos base container.
    * Moved hiera default yaml workaround to fuel/centos

    Change-Id: Ifd8740735c676f6e500795aa05123ede4d72ae92
    Closes-Bug: #1482232

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-main (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/238053

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/238053
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=e42edea9db95cc8c7aef9c6efb58681cdc067e6c
Submitter: Jenkins
Branch: master

commit e42edea9db95cc8c7aef9c6efb58681cdc067e6c
Author: Matthew Mosesohn <email address hidden>
Date: Wed Oct 21 16:02:45 2015 +0300

    Fix missing escape in nginx container

    Change-Id: I60a8e1393d8659367306ad36252cf237da66efeb
    Related-Bug: #1482232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-main (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/238109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/238110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/238110
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=d26eea511f0b90637e7d65cf1a93ca8b82502278
Submitter: Jenkins
Branch: master

commit d26eea511f0b90637e7d65cf1a93ca8b82502278
Author: Matthew Mosesohn <email address hidden>
Date: Wed Oct 21 17:15:58 2015 +0300

    Fix missing escape in nginx container

    Change-Id: I3ebca7905cc0c915189476bd4a86661a63e04722
    Related-Bug: #1482232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-main (master)

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/238109

Dmitry Pyzhov (dpyzhov)
tags: added: area-library
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.