custom repo named 'rabbitmq' will not appear on nodes after deployment

[Leontii Istomin]

I added custom repo on "settings" tab:
   name URI Priority
rabbitmq deb http://172.18.160.74/osci/review/LP-1463000/mos/7.0/cluster/base/trusty/ trusty main 1200

But can't see this repo on nodes after deployment:
root@node-1:~# ls -la /etc/apt/sources.list.d/
total 40
drwxr-xr-x 2 root root 4096 Jul 23 22:58 .
drwxr-xr-x 6 root root 4096 Jul 23 22:41 ..
-rw-r--r-- 1 root root 81 Jul 23 22:42 Auxiliary.list
-rw-r--r-- 1 root root 76 Jul 23 22:42 mos-holdback.list
-rw-r--r-- 1 root root 76 Jul 23 22:42 mos-security.list
-rw-r--r-- 1 root root 75 Jul 23 22:42 mos-updates.list
-rw-r--r-- 1 root root 75 Jul 23 22:42 mos.list
-rw-r--r-- 1 root root 78 Jul 23 22:42 ubuntu-security.list
-rw-r--r-- 1 root root 77 Jul 23 22:42 ubuntu-updates.list
-rw-r--r-- 1 root root 69 Jul 23 22:42 ubuntu.list

Cluster configuration:
Baremetal, Ubuntu,IBP, Neutron-gre,Ceph-all,Nova-debug,nova-quotas,7.0-73
Controllers:3 Computes+Cinder+Ceph:3

api: '1.0'
astute_sha: b1f37a988e097175cbbd14338286017b46b584c3
auth_required: true
build_id: 2015-07-22_23-50-18
build_number: '73'
feature_groups:
- mirantis
fuel-agent_sha: bc25d3b728e823e6154bac0442f6b88747ac48e1
fuel-library_sha: c174f646b40056668fad1fd62ee4bbb4d7902779
fuel-ostf_sha: 1672bf8908f8f506df5b2e63bd13b56aabbaf266
fuelmain_sha: 68871248453b432ecca0cca5a43ef0aad6079c39
nailgun_sha: 52a413e672b07396245bad16335870fffd8b7546
openstack_version: 2015.1.0-7.0
production: docker
python-fuelclient_sha: 7a29d1ac9b0d39290a45b4150b9157302ae0bf57
release: '7.0'

Diagnostic Snapshot: http://mos-scale-share.mirantis.com/fuel-snapshot-2015-07-24_09-02-02.tar.xz

[Vladimir Kozhukalov (kozhukalov)]

Looks like the first thing we need to do is to check if this additional repository was appended to other repos in serialized data.

[Ihor Kalnytskyi (ikalnytskyi)]

Leontiy, please provide a diagnostic snapshot.

[Alexander Gordeev (a-gordeev)]

Vladimir, nailgun has passed this repo to fuel-agent. It created granular tasks to upload settings to sources list and preferences.

All slave nodes have got preferences. /etc/apt/sources.list.d/rabbitmq.list is missing only on controllers.

astute logs showed that upload_file rabbitmq.list was completed without any errors.

mcollective logs doesn't show anything interesting to be happened during that.

[Ihor Kalnytskyi (ikalnytskyi)]

Sorry, diagnostic snapshot is attached as external link.

[Leontii Istomin (listomin)]

You can find link to the Diagnostic Snapshot in bug description

[Ihor Kalnytskyi (ikalnytskyi)]

Interesting thing - there's a preference file for this new repo. Hence, it looks like something has removed it.

[Ihor Kalnytskyi (ikalnytskyi)]

Ok, it's done by puppet. Just take a look onto /var/log/puppet.log:

22438 2015-07-23 23:36:33 +0000 /Stage[main]/Rabbitmq::Repo::Apt/Apt::Source[rabbitmq]/File[rabbitmq.list] (info): Starting to evaluate the resource
22439 2015-07-23 23:36:33 +0000 /Stage[main]/Rabbitmq::Repo::Apt/Apt::Source[rabbitmq]/File[rabbitmq.list] (info): Filebucketed /etc/apt/sources.list.d/rabbitmq.list to puppet wi th sum aab43476e352fd882dfc4b69e145b376
22440 2015-07-23 23:36:33 +0000 /Stage[main]/Rabbitmq::Repo::Apt/Apt::Source[rabbitmq]/File[rabbitmq.list] (debug): Removing existing file for replacement with absent
22441 2015-07-23 23:36:33 +0000 /Stage[main]/Rabbitmq::Repo::Apt/Apt::Source[rabbitmq]/File[rabbitmq.list]/ensure (notice): removed

Move it to fuel-library. As a workaround, I suggest to name the repo in other manner.

[Oleksiy Molchanov (omolchanov)]

Oh, rabbitmq repo is managed by puppet. In Fuel the default rule for this repo is absent, so please rename it and i think we should reserve this name in UI.

[Vitaly Kramskikh (vkramskikh)]

Read the whole description and comments twice and still have no idea what's wrong and what needs to be fixed. If it is about renaming some repo in the config, let fuel-library team do it.

[Oleksiy Molchanov (omolchanov)]

MOS puppet, can we make any work around to do that using upstream rabbit module?

[Ihor Kalnytskyi (ikalnytskyi)]

Just 5 cents here.

I'm strongly against implementing hacks on UI/Nailgun to forbid use "rabbitmq" name for the custom repo. It's ugly. It should be done somehow on puppet side. Perhaps, we should turn off in rabbimq manifest managing repos. If it's impossible to do, I'd prefer to mark it as Won't Fix.

Since it's not a common problem and we have an easy workaround, I'd propose to set Medium prio, but I left it for Library cores.

[Bogdan Dobrelya (bogdando)]

This is how upstream module works. If repos_ensure => false, the apt source named rabbitmq will be removed (ensure=> absent).
This is a minor UX bug and there is a simple workaround should be documented - do not use a name 'rabbitmq' for new repositories in UI.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222658
Committed: https://git.openstack.org/cgit/stackforge/fuel-docs/commit/?id=18e039a858e9e7d8846f55dc0bf5ff193d1d8ac2
Submitter: Jenkins
Branch: master

commit 18e039a858e9e7d8846f55dc0bf5ff193d1d8ac2
Author: Alexander Adamov <email address hidden>
Date: Fri Sep 11 18:02:12 2015 +0300

    [RN 7.0]Fuel install&deploy issues

    Adds resolved and known issues:
    LP1491725, LP1437410,
    LP1477903

    Change-Id: I87fcb333d632de6faa7071713f88e8519bccf8d7
    Related-Bug: #1491725
    Related-Bug: #1437410
    Related-Bug: #1477903