python-fuelclient should have an official OpenStack Infra python unit test jobs

Bug #1476808 reported by Boris Pavlovic
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Roman Prykhodchenko

Bug Description

Currently python-fuelclient has mixed integration and unit test:
https://github.com/stackforge/python-fuelclient/tree/master/fuelclient/tests/v1

Integration tests requires running Fuel which means that it's impossible to use
python jobs of OpenStack infra for gating.

This blocks moving OpenStack to Big Tent. I believe we should split unit and integration tests to achieve our goals.

Revision history for this message
Dmitry Borodaenko (angdraug) wrote :

Confirmed, we should be moving all tests that can run on OpenStack infra over there:
http://lists.openstack.org/pipermail/openstack-dev/2015-July/069908.html

For 7.0, this is High priority. If this gets pushed to 8.0 it will become Critical.

Changed in fuel:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Roman Prykhodchenko (romcheg)
milestone: none → 7.0
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

Tests should be redone for that https://review.openstack.org/#/c/172878/

I will restore the patch update and merge it. Then we will enable the job.

Changed in fuel:
status: Confirmed → Triaged
tags: added: module-client
Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207987

Revision history for this message
Mike Scherbakov (mihgen) wrote :

As this is devops/test-related activity, I've marked this as "non-release". It can be merged any time.

tags: added: non-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/172878
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=0d5928fd4f48f3ee48a28924dc68b2abd4780c94
Submitter: Jenkins
Branch: master

commit 0d5928fd4f48f3ee48a28924dc68b2abd4780c94
Author: Roman Prykhodchenko <email address hidden>
Date: Mon Apr 13 12:45:48 2015 +0200

    Redone the structure of test file tree

    Made the test file more compatible with the one
    in upstream OpenStack by putting all tests to
    tests/unit and tests/functional directories.

    That brings the following pros:

     - Allows to run unit or functional tests separately
     - Allows to reuse existing CI jobs

    Partial-bug: #1476808
    Change-Id: I322ddda5007a36db0e4376ea2eb5230a5fd4ed29

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/207987
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=224b490d7dcc352ff2aeb40065f0ca5291fe0aaf
Submitter: Jenkins
Branch: master

commit 224b490d7dcc352ff2aeb40065f0ca5291fe0aaf
Author: Roman Prykhodchenko <email address hidden>
Date: Fri Jul 31 18:47:27 2015 +0200

    Tox to manage all test environments on its own

    Functional tests have been moved to a separate tox
    enviroment called functional, so running either py26
    or py27 one will only trigger unit tests.

    Scripts for prepairing and cleaning up Nailgun environments
    have been factored out of run_tests.sh.

    run_tests.sh is kept just compatibility reasons and will be
    removed once FuelCI is updated.

    DocImpact
    Partial-bug: #1476808
    Closes-bug: #1486030
    Change-Id: I492ce5d1ed26a182cc6876594d4508088afd5411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/214650

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/214650
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=4dffff966042976f62ffd8fc338c7cf80c2e1aa1
Submitter: Jenkins
Branch: master

commit 4dffff966042976f62ffd8fc338c7cf80c2e1aa1
Author: Roman Prykhodchenko <email address hidden>
Date: Wed Aug 19 16:47:04 2015 +0200

    Support separate jUnit files for environments

    Otherwise they get overwritten by each other.

    Change-Id: Ib216a0eb302a62acbb5045cadb3a0c31074c40c2
    Related-bug: #1476808

Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

This patch resolved the bug.

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

The functional and unit tests are run separately (https://ci.fuel-infra.org/job/verify-python-fuelclient/627/console).

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.