fuel-library version of puppetlabs-haproxy is out of sync with the upstream

[Alex Schultz]

In comparing our haproxy module with the upstream, we have a number of changes from the upstream version.

When comparing 1.2.0 version of the module, here are the files that differ:

 deleted: puppet/haproxy/.fixtures.yml
 deleted: puppet/haproxy/.geppetto-rc.json
 deleted: puppet/haproxy/.gitignore
 deleted: puppet/haproxy/.nodeset.yml
 deleted: puppet/haproxy/.travis.yml
 modified: puppet/haproxy/Gemfile
 deleted: puppet/haproxy/lib/puppet/provider/haproxy_backend_status/haproxy.rb
 deleted: puppet/haproxy/lib/puppet/type/haproxy_backend_status.rb
 modified: puppet/haproxy/manifests/balancermember.pp
 deleted: puppet/haproxy/manifests/base.pp
 modified: puppet/haproxy/manifests/listen.pp
 modified: puppet/haproxy/manifests/params.pp
 deleted: puppet/haproxy/templates/haproxy-stats.cfg.erb
 modified: puppet/haproxy/templates/haproxy_balancermember.erb

We should adjust our usage/contribute upstream the differences.

[Vladimir Kuklin (vkuklin)]

This bug was partially addressed in 7.0. Complete sync should be completed in 8.0

[Vladimir Kuklin (vkuklin)]

otherwise, our ssl implementation will be broken

[Matthew Mosesohn (raytrac3r)]

I discussed with Alex Schultz. We are moving resync with upstream + librarian tasks to tech-debt tag.

[Stanislaw Bogatkin (sbogatkin)]

Why we should move this? We can create local upstream mirror and put our patches to a separate branch, then pull data via librarian from this branch. BTW, there is no way to merge our changes with upstream now - we tried to do it many times.

[Alex Schultz (alex-schultz)]

Because it is an upstream module, we should try and leverage the upstream without modifications. This bug is to indicate that the one that currently lives in fuel-library has custom changes. We should either figure out if a new version provides a way to do what we need or figure out an upstream agreeable change sets. We don't need to pull this out as part of 8.0 as the upstream openstack modules are more important, but if we get time we should evaluate our options. Pulling this module out and sticking it in fuel-infra as a custom fork is not better than just leaving it at the moment.

[Stanislaw Bogatkin (sbogatkin)]

We use modified version of upstream module to utilize ability of using 'conf.d' directory for haproxy. It is very convenient for us and we built custom haproxy package for every Fuel release because of it. Those patches will never be in upstream haproxy (it was discussed three or four times with haproxy developers), so our patches for puppet module will never be in upstream also. So, we have two options:

1. Use our changes rebasing them time to time to upstream master.
2. Drop our changes and refuse of ability using 'conf.d' for haproxy.

[Alex Schultz (alex-schultz)]

So that's fine, the point of this bug is to look into it to see if there is something else to do as it relates to puppet. In digging into the history on that thread there were other alternatives evidently so that one could specify -f multiple times and we could work around this by still having the folder but automatically adjusting the cmd line params with a simple script such as http://permalink.gmane.org/gmane.comp.web.haproxy/17603

The point of this bug is to bring up the tech debt so it is visible and we can devote time to reworking the situation. There may be another solution so we could stop having to do all this packaging stuff but no one has revisited it recently to find out. So if we get time, we can take all of this into consideration and hopefully improve things as a whole.