[fuel-web][nailgun] generators are not supported in fuel plugin environment_config.yaml

Bug #1473452 reported by Serg Lystopad on 2015-07-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Dmitry Stepanenko
7.0.x
Medium
Dmitry Stepanenko
8.0.x
High
Dmitry Stepanenko

Bug Description

Oleksiy Molchanov (omolchanov) wrote :

Nice issue description, anyway I am passing it to python team, perhaps this makes sense for them.

Changed in fuel:
milestone: none → 7.0
assignee: nobody → Fuel Python Team (fuel-python)
importance: Undecided → Low
status: New → Confirmed
Evgeniy L (rustyrobot) wrote :

Increased priority, because it's useful feature and it's a matter of swapping two lines [1]

[1] https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/cluster.py#L272-L280

Changed in fuel:
importance: Low → High
tags: added: module-nailgun
removed: nailgun
tags: added: feature
Changed in fuel:
status: Confirmed → Won't Fix
tags: added: qa-agree-8.0
summary: - [fuel-web][nailgun] generators is not supported in fuel plugin
+ [fuel-web][nailgun] generators are not supported in fuel plugin
environment_config.yaml

Fix proposed to branch: master
Review: https://review.openstack.org/217044

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Dmitry Stepanenko (dstepanenko)
status: Won't Fix → In Progress
Changed in fuel:
status: In Progress → Won't Fix
Changed in fuel:
status: Won't Fix → In Progress

Reviewed: https://review.openstack.org/217044
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d8608388bef3ea688886f6f723f8447ec5b7cbef
Submitter: Jenkins
Branch: master

commit d8608388bef3ea688886f6f723f8447ec5b7cbef
Author: Dmitry Stepanenko <email address hidden>
Date: Wed Aug 26 11:47:00 2015 +0300

    Fixed generators support in fuel plugin environment_config.yaml

    Fixed attributes processing mechanism in such a way that at the first step
    instance editable metadata attributes are merged with plugin attributes and
    only after that the resulting attributes dict goes through generator processing

    Change-Id: I4bda81f323a3f77ae5ace3927ac5f157503822ee
    Closes-bug: #1473452

Changed in fuel:
status: In Progress → Fix Committed
Vitaly Sedelnik (vsedelnik) wrote :

Dmitry, please review the fix and backport to 7.0 if applicable. If not, please update the status accordingly (Won't Fix or Invalid).

Dmitry Klenov (dklenov) wrote :

Setting status to 'Confirmed' as there is enough data to produce the fix.

Vitaly Sedelnik (vsedelnik) wrote :

Per conversation with Dmitry it's realistic to get the fix backported to 7.0-mu-1

tags: added: 70mu1-confirmed
Dmitry Pyzhov (dpyzhov) on 2015-10-22
tags: added: area-python
tags: added: on-verification

Reviewed: https://review.openstack.org/239935
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=153e0c0b5fcccabda969b7dc632f180f128f1864
Submitter: Jenkins
Branch: stable/7.0

commit 153e0c0b5fcccabda969b7dc632f180f128f1864
Author: Dmitry Stepanenko <email address hidden>
Date: Wed Aug 26 11:47:00 2015 +0300

    Fixed generators support in fuel plugin environment_config.yaml

    Fixed attributes processing mechanism in such a way that at the first step
    instance editable metadata attributes are merged with plugin attributes and
    only after that the resulting attributes dict goes through generator processing

    Change-Id: I4bda81f323a3f77ae5ace3927ac5f157503822ee
    Closes-bug: #1473452
    (cherry picked from commit d8608388bef3ea688886f6f723f8447ec5b7cbef)

Verified on the Fuel 8.0 #134 ISO

Steps used for verify:
1) Install Fuel master node
2) Install sample plugin (attached)
3) Make changes at the plugins directory on the master node at the file /var/www/nailgun/plugins/<plugin_name>/environment_config.yaml:
use this config:
attributes:
  fuel-plugin-test-generators_password:
    weight: 10
    label: 'Field for testing autogenerated values'
    type: "textarea"
    value:
      generator: "password"
4) Save changes.
5) Change MOS supported version at /var/www/nailgun/plugins/<plugin_name>/metadata.yaml:
use:
fuel_version: ['8.0']
releases:
  - os: ubuntu
    version: 2015.1.0-7.0
    mode: ['ha', 'multinode']
    deployment_scripts_path: deployment_scripts/
    repository_path: repositories/ubuntu
  - os: ubuntu
    version: 2015.1.0-8.0
    mode: ['ha', 'multinode']
    deployment_scripts_path: deployment_scripts/
    repository_path: repositories/ubuntu
6) Save changes
7) Create a new environment
8) Go to the Settings tab, there should be Testing subtab

Actual result:
There is a "Field for testing autogenerated values" label with auto generated password at the text field

tags: removed: 70mu1-confirmed
tags: removed: on-verification
tags: added: on-verification

Also verified on an updated Fuel 7.0 mu1.
Steps are equal to the steps from comment 10. Except one: we do not need to change support release versions at the step 5. So just skip it.

Actual result:
There is a "Field for testing autogenerated values" label with auto generated password at the text field

Moved to the Fix Released for 7.0-mu-1

tags: removed: on-verification
Dmitry Pyzhov (dpyzhov) on 2015-11-30
Changed in fuel:
milestone: 7.0 → 8.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers