Fuel syntax check should check all shell scripts for bashisms (which is POSIX:2001 in-compatibility) in order to improve the portability UX

Bug #1473307 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Fuel Sustaining
Mitaka
Won't Fix
Medium
Fuel Library (Deprecated)

Bug Description

Currently we check only for "bash -n" execution. We should also use the checkbashisms from the devscripts package.
Also, since the 6.1 release all of the binaries and shell scripts in fuel-library moved to ./files, the syntax check script paths must be adjusted to include the new location as well

Changed in fuel:
milestone: none → 7.0
assignee: nobody → Bogdan Dobrelya (bogdando)
importance: Undecided → Medium
status: New → In Progress
summary: Fuel syntax check should check all shell scripts for bashisms
+ (POSIX:2001 compatibility) in order to improve the portability UX
summary: - Fuel syntax check should check all shell scripts for bashisms
- (POSIX:2001 compatibility) in order to improve the portability UX
+ Fuel syntax check should check all shell scripts for bashisms (which is
+ POSIX:2001 in-compatibility) in order to improve the portability UX
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200410

Changed in fuel:
assignee: Bogdan Dobrelya (bogdando) → Sergii Golovatiuk (sgolovatiuk)
Changed in fuel:
assignee: Sergii Golovatiuk (sgolovatiuk) → Bogdan Dobrelya (bogdando)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/200410

tags: added: non-release
Changed in fuel:
status: In Progress → Won't Fix
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

Tagging system-tests and fuel-ci as this is not for bugfixing team.

tags: added: fuel-ci system-tests
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Bogdan Dobrelya (bogdando) → Fuel Library Team (fuel-library)
milestone: 7.0 → 8.0
status: Won't Fix → Confirmed
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Bartłomiej Piotrowski (bpiotrowski)
tags: added: team-bugfix
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 8.0 → 9.0
tags: added: tech-debt
tags: removed: fuel-ci non-release system-tests team-bugfix tech-debt
tags: added: tech-debt
tags: added: team-bugfix
Changed in fuel:
assignee: Bartłomiej Piotrowski (bpiotrowski) → Fuel Library Team (fuel-library)
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/newton
Changed in fuel:
assignee: Maksim Malchuk (mmalchuk) → Fuel Sustaining (fuel-sustaining-team)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.