Make rabbitmq OCF script POSIX compatible

Bug #1473015 reported by Bogdan Dobrelya on 2015-07-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
Bogdan Dobrelya
6.1.x
Medium
Rodion Tikunov
7.0.x
Medium
Denis Puchkin

Bug Description

In order to ease the rabbitmq OCF script upstream contributing effort, we have to address all of the bashisms and make the script POSIX compatible.

Changed in fuel:
milestone: none → 7.0
assignee: nobody → Bogdan Dobrelya (bogdando)
importance: Undecided → Medium
status: New → In Progress
tags: added: pacemaker rabbitmq
Changed in fuel:
assignee: Bogdan Dobrelya (bogdando) → Bartlomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Bartlomiej Piotrowski (bpiotrowski) → Bogdan Dobrelya (bogdando)

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/200412

Changed in fuel:
milestone: 7.0 → 8.0
milestone: 8.0 → 7.0
status: In Progress → Won't Fix
Bogdan Dobrelya (bogdando) wrote :

Since the RabbitMQ OCF script was accepted upstream and already contains the POSIX fixes, I suggest to not address this cosmetic changes in Fuel and just consume the OCF script out of box in later.

Fix proposed to branch: master
Review: https://review.openstack.org/235828

Changed in fuel:
status: Won't Fix → In Progress
Changed in fuel:
milestone: 7.0 → 8.0

Reviewed: https://review.openstack.org/235828
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=fe4edc4589ff37647134fdf83fc4e8896469cdd7
Submitter: Jenkins
Branch: master

commit fe4edc4589ff37647134fdf83fc4e8896469cdd7
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Oct 16 12:13:41 2015 +0200

    Sync rabbitmq OCF from upstream

    Sync upstream changes back to Fuel downstream
    Source https://github.com/rabbitmq/rabbitmq-server
    version stable/fedfefebaa39a0aeb41cf9328ba44c3a458e4614

    Related blueprint upstream-rabbit-ocf
    Closes-bug: #1473015

    Change-Id: Ie19c2f071c53b873a359c6c5134e9498c6391e66
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov) on 2015-10-22
tags: added: area-library

Change abandoned by Rodion Tikunov (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/273474
Reason: Will do for this cherry-pick a new commit

Bogdan Dobrelya (bogdando) wrote :

Note, the backport fixes the customer-found medium bug #1527518 and this one just as well.

tags: added: dev-to-verify
Bogdan Dobrelya (bogdando) wrote :

# head -1 files/fuel-ha-utils/ocf/rabbitmq
#!/bin/sh
# checkbashisms files/fuel-ha-utils/ocf/rabbitmq && echo OK
OK

Changed in fuel:
status: Fix Committed → Fix Released
Vitaly Sedelnik (vsedelnik) wrote :

Won't Fix for 7.0-updates because of Medium importance

tags: added: wontfix-low
Rodion Tikunov (rtikunov) wrote :

Won't Fix for 6.1-updates because of Medium importance

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/275189
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/285189
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers