nailgun-agent fails with 400 error for offloading_modes

[Matthew Mosesohn]

From nailgun-agent:
D, [2015-07-06T15:15:37.406553 #19322] DEBUG -- : Detailed meta disks: [{:name=>"sda", :model=>"VBOX HARDDISK", :size=>68718428160, :disk=>"sda", :extra=>["disk/by-id/ata-VBOX_HARDDISK_VBb25e9284-ea5b47b9"], :removable=>"0"}, {:name=>"sdb", :model=>"VBOX HARDDISK", :size=>68718428160, :disk=>"sdb", :extra=>["disk/by-id/ata-VBOX_HARDDISK_VBffa3ff94-dd84f826"], :removable=>"0"}, {:name=>"sdc", :model=>"VBOX HARDDISK", :size=>68718428160, :disk=>"sdc", :extra=>["disk/by-id/ata-VBOX_HARDDISK_VB96ca1c19-0e9a9bdd"], :removable=>"0"}]
D, [2015-07-06T15:15:37.439095 #19322] DEBUG -- : Response: status: 400 body: {"message": "offloading_modes: None is not of type 'array'", "errors": []}
E, [2015-07-06T15:15:37.439557 #19322] ERROR -- : {"message": "offloading_modes: None is not of type 'array'", "errors": []}

From nailgun/api.log:
api.log:2015-07-06 15:18:24.655 DEBUG [7f7783819740] (logger) Request POST /api/nodes/ from 10.20.0.6:57330 {"mac":"08:00:27:EC:D9:B7","ip":"10.20.0.6","os_platform":"ubuntu","manufacturer":"VirtualBox","platform_name":null,"meta":{"system":{"manufacturer":"VirtualBox","serial":"0","uuid":"D6C313E8-F09C-4FB6-B83B-CEDF84F400C7","family":"Virtual Machine","version":"1.2","fqdn":"node-4.domain.tld"},"interfaces":[{"name":"eth0","state":"unknown","mac":"08:00:27:EC:D9:B7","driver":"pcnet32","bus_info":"0000:00:03.0","max_speed":100,"current_speed":100,"ip":"10.20.0.6","netmask":"255.255.255.0","offloading_modes":null},{"name":"eth1","state":"down","mac":"08:00:27:8A:FD:D6","driver":"pcnet32","bus_info":"0000:00:08.0","max_speed":100,"current_speed":100,"offloading_modes":null},{"name":"eth2","state":"down","mac":"08:00:27:57:A2:84","driver":"pcnet32","bus_info":"0000:00:09.0","max_speed":100,"current_speed":100,"offloading_modes":null}],"cpu":{"total":1,"real":1,"spec":[{"frequency":2000,"model":"Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz"}]},"disks":[{"name":"sda","model":"VBOX HARDDISK","size":68718428160,"disk":"sda","extra":["disk/by-id/ata-VBOX_HARDDISK_VBe1d290f5-a311dec0"],"removable":"0"},{"name":"sdb","model":"VBOX HARDDISK","size":68718428160,"disk":"sdb","extra":["disk/by-id/ata-VBOX_HARDDISK_VBcb535f8d-3394f945"],"removable":"0"},{"name":"sdc","model":"VBOX HARDDISK","size":68718428160,"disk":"sdc","extra":["disk/by-id/ata-VBOX_HARDDISK_VBc5c91323-e93d5c37"],"removable":"0"}],"memory":{"total":2667552768}},"is_agent":true,"agent_checksum":"aff1f5b16cd5ae9b763de08ba667e353f963ec3c"}

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "7.0"
  openstack_version: "2014.2.2-7.0"
  api: "1.0"
  build_number: "196"
  build_id: "2015-07-06_11-20-37"
  nailgun_sha: "5ef9c286c76a7cc83e2bc39abf0f0e1f25136bfa"
  python-fuelclient_sha: "315d8bf991fbe7e2ab91abfc1f59b2f24fd92f45"
  astute_sha: "9cbb8ae5adbe6e758b24b3c1021aac1b662344e8"
  fuel-library_sha: "74e7668d3940f42ce1f5644ea59de54056b80195"
  fuel-ostf_sha: "531950bb1090caa8cfb0ef4d7957b5e48e801bb4"
  fuelmain_sha: "4f2dff3bdc327858fa45bcc2853cfbceae68a40c"

[Vladimir Sharshov (vsharshov)]

Problem affect only Ubuntu, but, i think, good idea to add it explicitly for CentOS.

Build custom iso with changes to check.

Reviews:

- https://review.openstack.org/#/c/198787/ (CentOS);
- https://review.openstack.org/#/c/198785/ (Ubuntu).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vladimir Sharshov (<email address hidden>) on branch: master
Review: https://review.openstack.org/198787
Reason: Including ethtool like depends for CentOS package

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: master
Review: https://review.openstack.org/198808
Reason: Evgeniy Li already reverted this

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/198785
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=aac0de650c77d17a10e5e7f080499350aa911394
Submitter: Jenkins
Branch: master

commit aac0de650c77d17a10e5e7f080499350aa911394
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Mon Jul 6 18:33:50 2015 +0300

    Missing nailgun-agent depends: ethtool

    We use ethtool to collect data about available
    offloading modes for physical interfaces

    Change-Id: Ie6528306fe56a9999782fa6a3e6fbc8ee7af33d0
    Closes-Bug: #1471856

[Maksym Strukov (unbelll)]

Following tests passed:

https://mirantis.testrail.com/index.php?/tests/view/1630762
https://mirantis.testrail.com/index.php?/tests/view/1630763

Assume bug fixed.