Predefined networks creation is hardcoded

[Dmitry Nikishov]

MOS 6.0, Neutron+VLAN, any OS

Currently, predefined networks (net04/net04_ext) creation is hardcoded in puppet manifests (see /etc/puppet/openstack/manifests/controller.pp:660).

We've got a case, when customer has limited amount of VLANs available (28). After the cloud has been deployed, net04 was deleted. Instead, 28 networks/tenants were created.

During controller replacement/scaling procedure puppet tries to create hardcoded networks, however due to all VLANs being occupied by existing Neutron networks, net04 cannot be created. This leads to a failed deployment.

Creation of predefined networks should be optional.

[Aleksandr Didenko (adidenko)]

Fix to fuel-library proposed https://review.openstack.org/198811

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/200530

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/200530
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f093b603d7e5c31d40c26329e8e5b99e1063b61b
Submitter: Jenkins
Branch: master

commit f093b603d7e5c31d40c26329e8e5b99e1063b61b
Author: Oleg Gelbukh <email address hidden>
Date: Fri Jul 10 08:37:54 2015 +0000

    Make predefined_networks parameter optional

    Only create predefined networks in Neutron if 'predefined_network' attribute in
    clster settings is present and not empty. Otherwise, skip this part of manifest.

    So, if you need to skip creation of predefined networks, delete this parameter
    or leave it empty in deployment settings.

    It is important to note that if user disabled creation of predefined networks,
    some components that depend on them might fail to install. The list
    (non-comprehensive) includes:

    * Murano
    * Sahara
    * Mellanox plugin for Neutron

    Other services might be impacted as well.

    Change-Id: Iceed16072628cced6de9f8704b35f21fd4342e87
    Closes-bug: 1471244
    DocImpact

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 6.0-updates because there is to way to deliver updates of puppet manifest in 6.0

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/198811

[Oleksiy Molchanov (omolchanov)]

Verified

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  api: "1.0"
  build_number: "284"
  build_id: "284"
  nailgun_sha: "5c33995a2e6d9b1b8cdddfa2630689da5084506f"
  python-fuelclient_sha: "1ce8ecd8beb640f2f62f73435f4e18d1469979ac"
  fuel-agent_sha: "082a47bf014002e515001be05f99040437281a2d"
  fuel-nailgun-agent_sha: "d7027952870a35db8dc52f185bb1158cdd3d1ebd"
  astute_sha: "8283dc2932c24caab852ae9de15f94605cc350c6"
  fuel-library_sha: "f81fdabe6c05be7a3d11d88a7c3a8f3931921c73"
  fuel-ostf_sha: "1f08e6e71021179b9881a824d9c999957fcc7045"
  fuelmain_sha: "9ab01caf960013dc882825dc9b0e11ccf0b81cb0"

[Alexey Stupnikov (astupnikov)]

I have tried to backport fix https://review.openstack.org/200530 to MOS 6.1 and had no success: since patched puppet manifest uses local node's hiera DB to get its settings and nothing in its generation process was changed, predefined_networks subsection of quantum_settings section still exists.

I have talked with Oleg Gelbukh and he told me that patch should work if deployment info doesn't have predefined_networks section. It was true in my test environment, but patch didn't help because Fuel still generates incorrect astute.yaml file for slave nodes.

IMO at this point we should decide bug's impact for MOS 6.1 and think about possible WA.

[Alexey Stupnikov (astupnikov)]

Changed status to 'Won't Fix' for MOS 6.1. Reason: it really doesn't fix this issue for 6.1. At this point in MOS 6.1 Puppet configures predefined networks unconditionally; patch fixes this behaviour. Patched manifest uses information from deployment_info, provided by astute and generated by nailgun. But nailgun also puts predefined networks configuration in deployment info unconditionally and it couldn't be changed without nailgun patch.
IMO possible nailgun patch which disables generation of predefined networks config is a feature request and it will change MOS behaviour for most users.

[Oleg S. Gelbukh (gelbuhos)]

It seems that we have regression of this bug in 8.0. The openstack-network module was completely rewritten, and the predefined_networks parameter became mandatory again.

[Denis Meltsaykin (dmeltsaykin)]

Assigning to Fuel Library team, as the solution won't fit into 8.0's code. There should be made a new solution.

[Sergey Vasilenko (xenolog)]

I set "won't fix" for this bug, because this is not a bug. This looks like new small feature.

[Sergey Vasilenko (xenolog)]

for 8.0 this may be implemented as plugin

[Oleg S. Gelbukh (gelbuhos)]

Sergey, this is clearly a regression in 8.0.