Message about resetting environment after stopping deploy on the post_deployment stage

[Alexander Kurenyshev]

Steps to reproduce:
1) Install master node
2) Create environment
3) Deploy cluster
4) Wait until post_deployment tasks will be executed
5) Stop Deploy

Expected result:
Deploy is stopped. There is a message from astute that we need to reset environment.

Actual result:
Deploy is stopped. Nodes are in the ready state, Deploy Changes button is disabled. (see picture)

[Ihor Kalnytskyi (ikalnytskyi)]

@Alexander,

Why do you expect message that we need to reset env? I always thought we shouldn't reset env after stopping.

As far as I know the Stop feature was designed the following way:

* if we didn't deploy critical node roles - we're resetting entire

* if we do have deployed critical node roles - we stop deploying new nodes and keep what was deployed as is (since it should be a working openstack cluster).

Looks invalid to me. Please correct me if I'm wrong.

[Nastya Urlapova (aurlapova)]

@Igor, we have agreement with Dima P., that we will block stop deploy action when we run post deployment tasks. This issue exactly about it.

[Ihor Kalnytskyi (ikalnytskyi)]

@Nastya,

I don't understand what's wrong. We do have exactly the same behavior in 6.0 - if we stop deploying cluster which has deployed critical nodes it won't be reseted.

BTW, why this bug is High?! It doesn't look like High at all, because it doesn't break anything.

[Ihor Kalnytskyi (ikalnytskyi)]

I don't see how it could be resolved soon in 6.1.

Currently, Nailgun doesn't know what deployment stage is now. In other words, it knows nothing about 'pre_deployment', 'deployment' and 'post_deployment' stages. Taking into account that fact the fix will require passing this information from Astute to Nailgun, and that, imo, a bit dangerous to do in late 6.1.

What can we do is to

* either hack this in fuel ui, so it won't show "Stop deployment" button in case if all nodes are ready
* or mark this issue as Medium and move it to 7.0, because user impact is small (i don't know why someone may want to stop deployment when it's almost done).

The second one is more preferable way, imo.

[Nastya Urlapova (aurlapova)]

Folks, we have to fix in 6.1 as simple as possible way.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/192106

[Ihor Kalnytskyi (ikalnytskyi)]

@Nastya,

There's no simple fix. It could be done only by changing communication protocol between Astute and Nailgun, and that's really danger if we want RC2 to be the final build.

Still, I've prepared a patch that extends "stop deployment" message. Since now it looks like -

"""Deployment of environment '{0}' was successfully stopped. Please reset the environment if you want to redeploy it."""

Is it ok for you? Here's the patch https://review.openstack.org/#/c/192106/ , please +1 if it's ok for you.

P.S: I strongly believe that this bug is not High since it's incredible rare case - no one will try to stop deployment when it shows 100% and all nodes have status ready (and that's exactly what we have in post_deployment stage).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/192106
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=57dbe5bf2ce5951252ab3b2cdd2e54b103cb6858
Submitter: Jenkins
Branch: master

commit 57dbe5bf2ce5951252ab3b2cdd2e54b103cb6858
Author: Igor Kalnitsky <email address hidden>
Date: Tue Jun 16 11:39:05 2015 +0300

    Extend stop deployment message

    If deployment was stopped show information that user should reset the
    env if he wants to redeploy it.

    Closes-Bug: #1464326

    Change-Id: I37f7e1c4ca91a6d9f2d23209955c0d3258e504b9
    Signed-off-by: Igor Kalnitsky <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/192156

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/192156
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=fa8dec50f3df2626c97f6c38a897cf4e0f80b39d
Submitter: Jenkins
Branch: stable/6.1

commit fa8dec50f3df2626c97f6c38a897cf4e0f80b39d
Author: Igor Kalnitsky <email address hidden>
Date: Tue Jun 16 11:39:05 2015 +0300

    Extend stop deployment message

    If deployment was stopped show information that user should reset the
    env if he wants to redeploy it.

    Closes-Bug: #1464326

    Change-Id: I37f7e1c4ca91a6d9f2d23209955c0d3258e504b9
    Signed-off-by: Igor Kalnitsky <email address hidden>