fuelmenu reports duplicating ip address by comparing it with itself

[Tigran]

Tested on Dell R210 fuel-community-6.1-266-2015-06-09_05-40-59.iso, boot from usb stick.
in fuelmenu i tried to set up eth5 interface by giving to it 10.10.0.10 address.
When applied changes, everything went fine, the eth5 got 10.10.0.10; but when pressed check button, it claimed that it is a duplicating ip address.

The same happens with the default 10.20.0.2 address for PXE boot.

Note: all interfaces are connected to one switch.

Workaround:
the test is done by running arping; /usr/lib/python2.6/site-packages/fuelmenu/common/network.py line around 83
replaced temporarily arping with a dummy script returning 0

[Andrey Maximov (maximov)]

Matt,
please take a look. You wrote the code which verifies IP duplication (https://github.com/stackforge/fuel-web/commit/f9d9c89d8a943cecceda2102adbcdd73397ef158)

[Matthew Mosesohn (raytrac3r)]

There is no justifiable reason to configure multiple interfaces on the admin network. You should just deactivate all but one interface for this network to work around this. I can modify the duplicate IP check call to filter macs from known local interfaces. Moving to 7.0 and medium

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/190089

[Andrew Woodward (xarses)]

customer found, needs to be backported

[Dmitry Pyzhov (dpyzhov)]

Reopening because of revert of the fix

[Vladimir Kuklin (vkuklin)]

I think, we can safely downgrade this issue to medium one. 1st of all it is a rare case where such check cannot reliably work - you should not have 2 interfaces for admin network in the same space or you should at least bond them. So far there is a workaround available. I think, we can mark it as medium and provide documentation on how to avoid such issue. Or, we can detect that there were 2 interfaces configured and disable this check showing corresponding warning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/213695

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/213695
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=6410677ada8107b41987bf8d6bc2ca4bc5625ff2
Submitter: Jenkins
Branch: master

commit 6410677ada8107b41987bf8d6bc2ca4bc5625ff2
Author: Matthew Mosesohn <email address hidden>
Date: Mon Aug 17 14:50:21 2015 +0300

    Bind to IP in arping if requested IP already assigend

    Arping can't detect duplicates if there is a second
    activated interface on the same LAN. It can be worked
    around by binding to the requested IP address when
    trying to detect duplicates.

    Change-Id: I3d47b85ddd1a8894e6a2526e1a42e9cbd0b4de52
    Closes-Bug: #1463418

[Peter Zhurba (pzhurba)]

Reproduced on MOS 7.0 ISO #299,

eth0 and eth4 connected into the same bridge

Step to reproduce
install fuel from iso

in fuelmenu

1 add 10.109.5.2/24 net on eth4
2 disable eth0
3 switch pxe from eth0 to eth4 and press check

obtain "Duplicate host found with IP 10.109.5.2"

[Matthew Mosesohn (raytrac3r)]

We're not fixing this for 7.0 any further since it can be worked around by not configuring 2 nics on the same LAN.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/227302

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/227302
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4eb54f6b367a80fda810347628477bbf82a09219
Submitter: Jenkins
Branch: master

commit 4eb54f6b367a80fda810347628477bbf82a09219
Author: Matthew Mosesohn <email address hidden>
Date: Thu Sep 24 16:24:50 2015 +0300

    Add arping bind for duplicate IP check on PXE setup

    This was done already for interface configuration,
    but was missed previously in commit
    6410677ada8107b41987bf8d6bc2ca4bc5625ff2

    Corrected iteritems to itervalues for assigned_ips.

    Change-Id: Ia68997db203a1ae7c888ee311ab239740526e8f1
    Closes-Bug: #1463418

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/230452

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230452
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4691ddee26ea7ddcc6aa7cdcf6a19edcf00e544f
Submitter: Jenkins
Branch: stable/7.0

commit 4691ddee26ea7ddcc6aa7cdcf6a19edcf00e544f
Author: Matthew Mosesohn <email address hidden>
Date: Thu Sep 24 16:24:50 2015 +0300

    Add arping bind for duplicate IP check on PXE setup

    This was done already for interface configuration,
    but was missed previously in commit
    6410677ada8107b41987bf8d6bc2ca4bc5625ff2

    Corrected iteritems to itervalues for assigned_ips.

    Change-Id: Ia68997db203a1ae7c888ee311ab239740526e8f1
    Closes-Bug: #1463418
    (cherry picked from commit 4eb54f6b367a80fda810347628477bbf82a09219)

[Artem Panchenko (apanchenko-8)]

verified on 7.0 MU1

[Nastya Urlapova (aurlapova)]

Moved to fix Released due to comment above.

[Denis Meltsaykin (dmeltsaykin)]

Closing this as Won't Fix for 6.1, as there is a workaround mentioned in comment #11

[isoboroff (isoboroff)]

I hit this bug on 7.0 in a slightly different way. This is a SuperMicro 2U box with 2 NICs in it. I want one NIC to talk to the cluster nodes and the other to sit on our normal network.

On a fresh DVD install, when I get to the fuelmenu, if I don't touch the network settings at all from the default, and go to the PXE Config menu and click 'check', it reports 'No Errors'.

If I go and enable eth1, setting it up for our office network, then go back and check the PXE settings, it reports a duplicate 10.20.0.1 host. Note that 10.20.0.1 is the default IP assigned on eth0 in the default settings in a fresh install. No other machines behind this switch are on, except for IPMI BMCs listening on a 192.168 network.

If I then go and deactivate eth1, so again we are at the default settings from a fresh install, and then check the PXE settings, it still reports the duplicate 10.20.0.1.

I have found no approach to settings for networking or PXE that work once I change them from the default. In the end, I just let the system complete the install using the default network settings, figuring I would fix them later.

[Artem Panchenko (apanchenko-8)]

verified

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "570"
  build_id: "570"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "c2a335b5b725f1b994f78d4c78723d29fa44685a"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"