Assuming br-storage interface for storage role crashes installations

[Noam Angel]

Assuming br-storage interface for storage role crashes installations.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "502"
  build_id: "2015-06-03_16-41-32"
  nailgun_sha: "14fe9a29dc06b9a9d4e12afcae73d2eea89575dc"
  python-fuelclient_sha: "4fc55db0265bbf39c369df398b9dc7d6469ba13b"
  astute_sha: "cbae24e9904be2ff8d1d49c0c48d1bdc33574228"
  fuel-library_sha: "fa9fbf458679df621973b97b1e4b6f82e1601db0"
  fuel-ostf_sha: "f899e16c4ce9a60f94e7128ecde1324ea41d09d4"
  fuelmain_sha: "bcc909ffc5dd5156ba54cae348b6a07c1b607b24"

https://github.com/stackforge/fuel-library/blame/42df864217042cd2be03fde25ba6c235835d4835/deployment/puppet/osnailyfacter/modular/swift/swift.pp#L55-56

The code should be like: $network_scheme['endpoints'][$network_scheme['roles']['storage']]['IP']
It should look at hiera roles section in network_scheme to understand what are the roles interfaces:
this is what we have:
 "roles"=>
  {"ex"=>"br-ex",
   "fw-admin"=>"br-fw-admin",
   "management"=>"br-mgmt",
   "neutron/floating"=>"br-floating",
   "neutron/private"=>"br-prv",
   "storage"=>"eth_iser0.3"},

wrong assumption "storage" => "br-storage" and calls it directly
and br-mgmt too

it crash all our ISER installations.

[Noam Angel (noama)]

snapshot:

https://drive.google.com/file/d/0B6QXR6Al7IxoY2xWTTRmOHlkajg/view?usp=sharing

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/188471

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/188471
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d98bf2f5f32ae973d6e95ad54ee0f8ae3bee6c40
Submitter: Jenkins
Branch: master

commit d98bf2f5f32ae973d6e95ad54ee0f8ae3bee6c40
Author: Vladimir Kuklin <email address hidden>
Date: Thu Jun 4 19:25:44 2015 +0300

    Fix wrong assumption of endpoint names

    This change comes to fix the wrong assumption that br-storage
    and br-mgmt are the storage and management endpoint names,
    and instead, use the value of the roles dictionary.

    Closes-Bug: #1462005

    Change-Id: I53c20fffc7b7a126d448640d23f110751b683abb