fuel-logrotate: pgrep output is not redirected to /dev/null

Bug #1461100 reported by Bartłomiej Piotrowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Bartłomiej Piotrowski
6.0.x
Invalid
Undecided
Unassigned

Bug Description

Fuel-logrotate uses pgrep to check if another instance of logrotate is already running. When it is, its output (PID) should be redirected to /dev/null, but due to '/bin/sh' shebang, '&>' redirection doesn't work properly.

The problem results in cluttered mail spool for root user.

Tags: logging
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187591

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/187591
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=bc8db51136ed5c9ab34ef66eb5b6c3dd6143badb
Submitter: Jenkins
Branch: master

commit bc8db51136ed5c9ab34ef66eb5b6c3dd6143badb
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Jun 2 15:44:44 2015 +0200

    Redirect fuel-logrotate's pgrep output to /dev/null

    On Ubuntu nodes, root's mail spool occasionally gets cluttered by
    mysterious numbers coming from fuel-logrotate. Some might think it's a
    message from aliens, but in fact Ubuntu symlinks /bin/sh (which is used in
    script's shebang) to fully POSIX-compliant dash. It doesn't understand
    '&>' syntax, is custom bash extension. It has been replaced with proper,
    portable redirection.

    Change-Id: I43d135b341fd83eaed35d92d3e93eec9610d6af9
    Closes-Bug: 1461100

Changed in fuel:
status: In Progress → Fix Committed
tags: added: logging
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.