[Fuel-OSTF] 'assert' in test.py is needless

[Oleksandr Kyrylchuk]

In file test.py, there's such block:

https://github.com/stackforge/fuel-ostf/blob/master/fuel_health/test.py#L84-L86

In fact, this block does nothing useful (OSTF tests work fine even after commenting a line with 'assert').
Also, this assertion causes critical problems for Cloudvalidation Project, where such assertion provokes crash while trying to run a test suite.

So, there can be a reason of removing this assertion from test.py file.

[Tatyanka (tatyana-leontovich)]

does not affect ostf at all, just code clean up, so move to the wishlist

[Sebastian Kalinowski (prmtl)]

I'm tempted to make it as Invalid/Wont Fix since there is a comment explaining the need of this assert. I would rather consider fixing bug on Cloudvalidation Project.

Please describe what is exactly wrong and example of the issue.

[Oleksandr Kyrylchuk (okyrylchuk)]

@prmtl: Generally speaking, you're right. Let me explain the situation.

In Cloudvalidation Project we implemented an Adapter for OSTF tests which is more flexible than the one from OSTF project (it does not require nailgun for running the tests). For this reason we needed just to register some additional options, but ran into the specific features in fuel-ostf. For now we have a workable solution except the problem of 'assert' mentioned in topic. With this assertion commented, we ran OSTF against MOS 6.X in Fuel Dashboard and against devstack with our Adapter: both worked fine. It seems that such simple fix should not reduce stability of Fuel OSTF, but it would enable running OSTF tests against almost any Openstack cloud.

@tatyana-leontovich: Sure, from the point of OSTF itself it's rather 'nice to have'.

[Tatyanka (tatyana-leontovich)]

Timur why do we set invalid here? Is it stop affect @Oleksander?

[Timur Nurlygayanov (tnurlygayanov)]

Tatyana, we discussed the issue and looks like it is not bug in OSTF itself. Of course we can change this part of code, I know the right way and will prepare the fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/200576

[OpenStack Infra (hudson-openstack)]

Change abandoned by tatyana-leontovich (<email address hidden>) on branch: master
Review: https://review.openstack.org/200576

[Tatyanka (tatyana-leontovich)]

I'm tempted to make it as Invalid/Wont Fix since there is a comment explaining the need of this assert. I would rather consider fixing bug on Cloudvalidation Project.

Please describe what is exactly wrong and example of the issue.