IBP: fuel-agent should handle socket.timeout exception

[Roman Vyalov]

http://jenkins-product.srt.mirantis.net:8080/job/6.1.staging.ubuntu.bvt_2/367/console
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/helpers/decorators.py", line 414, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/helpers/decorators.py", line 463, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/helpers/decorators.py", line 470, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/helpers/decorators.py", line 356, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/models/fuel_web_client.py", line 727, in deploy_cluster_wait
    self.assert_task_success(task, interval=interval)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/__init__.py", line 48, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.staging.ubuntu.bvt_2/fuelweb_test/models/fuel_web_client.py", line 267, in assert_task_success
    task['status'], 'ready', name=task["name"]
AssertionError: Task 'deploy' has incorrect status. error != ready

[Tatyanka (tatyana-leontovich)]

why this issue is assigned on QA team, if we look at the env or in logs, we can see that cluster has error state, according to next problem
http://paste.openstack.org/show/235626/

[Tatyanka (tatyana-leontovich)]

http://paste.openstack.org/show/235627/

[Alexander Gordeev (a-gordeev)]

https://github.com/stackforge/fuel-web/blob/master/fuel_agent/fuel_agent/utils/build_utils.py#L429
fuel-agent got unexpected (in terms of exception handling) network connectivity related issue. Should be fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185436

[Alexander Gordeev (a-gordeev)]

to be precise it's python-requests related issue. It doesn't handle socket.timeout proreply.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185436
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=78250a2c44a84ea0ebca9942a63b6658ebbc3b6a
Submitter: Jenkins
Branch: master

commit 78250a2c44a84ea0ebca9942a63b6658ebbc3b6a
Author: Alexander Gordeev <email address hidden>
Date: Mon May 25 20:46:08 2015 +0300

    IBP: Fix socket.timeout catching

    Recent version of python-requests doesn't catch socket.timeout()
    This patch resolves the issue by explicit adding socket.timeout to
    the list of expected exceptions to be caught.

    Change-Id: Ifcadf9efbec633175bb1bd31cf7f58732c2e78c4
    Closes-Bug: #1458526