Add an illegal characters list for the helper in the "Setting->VMware" tab

Bug #1457911 reported by Ruslan Khozinov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Low
Anton Zemlyanov

Bug Description

When I tried to set the "vm-cluster1" value to the "Service name" filed I've seen the error "Invalid service name" and I've spent some time before I've found that "-" is prohibited.

I think it's not good to confuse our users, so I suggest to add a list of illegal characters to the helper for the "Service name" field.

Fuel version:

{"build_id": "2015-05-22_03-56-41", "build_number": "450", "release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-22_03-56-41", "build_number": "450", "api": "1.0", "fuel-library_sha": "9f4d5ec1944f01c238d1cc2faf146486d1c9f0c1", "nailgun_sha": "50889f0ffc31f5c12f0ba2f72f0f33ae57da057b", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "e39046ab9f35d6a49603e06cc12487a8b2f0aaab", "fuel-ostf_sha": "a4b5864ab99d7f93ed7264ce17d80e7998fda875", "release": "6.1", "fuelmain_sha": "5c8ebddf64ea93000af2de3ccdb4aa8bb766ce93"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "9f4d5ec1944f01c238d1cc2faf146486d1c9f0c1", "nailgun_sha": "50889f0ffc31f5c12f0ba2f72f0f33ae57da057b", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce", "astute_sha": "e39046ab9f35d6a49603e06cc12487a8b2f0aaab", "fuel-ostf_sha": "a4b5864ab99d7f93ed7264ce17d80e7998fda875", "release": "6.1", "fuelmain_sha": "5c8ebddf64ea93000af2de3ccdb4aa8bb766ce93"}

Revision history for this message
Ruslan Khozinov (rkhozinov) wrote :
description: updated
Igor Zinovik (izinovik)
Changed in fuel:
importance: Undecided → Low
milestone: none → 7.0
tags: added: low-hanging-fruit
Andrian Noga (anoga)
Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Fuel Partner Core (fuel-partner-core) → Anton Zemlyanov (azemlyanov)
Revision history for this message
Anton Zemlyanov (azemlyanov) wrote :

fixed, '-' is alowed at any positon exluding first

Revision history for this message
Anton Zemlyanov (azemlyanov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215614

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
milestone: 7.0 → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/215614
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b2dc3075d010ff7df3d5d2e83f5c7829e3a57153
Submitter: Jenkins
Branch: master

commit b2dc3075d010ff7df3d5d2e83f5c7829e3a57153
Author: Anton Zemlyanov <email address hidden>
Date: Fri Aug 21 15:59:23 2015 +0400

    Allow hyphen on service name for VMware

    Hyphen symbol added as the valid symbol for service name.
    Can be used in any but the first position

    Change-Id: I7cf1ce2ea6da31aba872f1efd8b2149b29edc472
    Closes-Bug: 1457911

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #141

{"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "3303f41f99cf9167da01d503dd5d2c8dab141447", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "141", "build_number": "141", "auth_required": true, "fuel-library_sha": "cd1b4b67d2b00fb10264d6626327688b170f0bf8", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1479c0b03ad928f2ea2a819fbf8218cff32e51b9", "fuel-agent_sha": "cf699820fb0a4d20bef001861e006dc9797b5733", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "3303f41f99cf9167da01d503dd5d2c8dab141447", "astute_sha": "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "141", "build_number": "141", "fuel-library_sha": "cd1b4b67d2b00fb10264d6626327688b170f0bf8", "fuel-nailgun-agent_sha": "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3", "fuel-nailgun_sha": "1479c0b03ad928f2ea2a819fbf8218cff32e51b9", "fuel-agent_sha": "cf699820fb0a4d20bef001861e006dc9797b5733", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0"}}}

Changed in fuel:
status: Fix Committed → Fix Released
Dmitry Pyzhov (dpyzhov)
tags: added: area-partners
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.