Puppet must cast to string values

[Mike Scherbakov]

Please take a look at Bug #1454708. While the bug itself is fixed now, the solution is not reliable. Developers & deployment engineers, as humans, can modify yaml at any given point of time without knowing that any value has to be quoted.

I understand that python code will always put values in quotas, but it doesn't yet mean that fuel-qa code will do it, or any other human modification in place will follow the rule.

Can we instead ensure that puppet does cast to string?

[Dmitry Ilyin (idv1985)]

Actually it's a Hiera bug. It should cast non-structure values to strings. Perhaps the same can happen with symbol values too.

[Aleksandr Didenko (adidenko)]

It's not Puppet or Hiera bug, it's how ruby YAML interprets unquoted numbers like 08:00:27:32:56:08. Just run this simple test:

echo 'mac: 08:00:27:32:56:08' > /tmp/zzz.yaml
ruby -e "require 'yaml'; puts YAML.load_file('/tmp/zzz.yaml').inspect"

Result:
{"mac"=>1960347}

So the only way to change this behaviour is to change it in ruby "yaml" library. Marking bug as invalid for Fuel.

[Mike Scherbakov (mihgen)]

I agree that mac has to be passed as a string. If it's passed as a number, then it is an issue indeed.

[Sergey Vasilenko (xenolog)]

I disagree with it:

> So the only way to change this behaviour is to change it in ruby "yaml" library.
> Marking bug as invalid for Fuel.

If we quote this value in the yaml file -- ruby will interpretate this value as text

# echo "mac: '08:00:27:32:56:08'" > /tmp/zzz.yaml
# ruby -e "require 'yaml'; puts YAML.load_file('/tmp/zzz.yaml').inspect"
{"mac"=>"08:00:27:32:56:08"}

[Sebastian Kalinowski (prmtl)]

Sergey, you reassigned, confirmed and rised priority of this bug, but you didn't wrote what exactly you expect form fuel-python to do in this case.

[Aleksandr Didenko (adidenko)]

Sergey, please read the bug description, the thing that you want has been fixed already in https://bugs.launchpad.net/fuel/+bug/1454708. This bug is about default behavior when key value is not quoted. I'm closing this bug as Invalid again.