Unable to compile plugin with fpb 2.x

Bug #1455196 reported by Claude Durocher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Artem Roma

Bug Description

Environment:

Ubuntu 14.04
fpb 2.0.1

Steps to reproduce:

sudo pip install fuel-plugin-builder
mkdir ~/Téléchargement
cd ~/Téléchargement
fpb --create fuel_plugin
fpb --build fuel_plugin

Ends with error :

Unexpected error 'ascii' codec can't decode byte 0xc3 in position 55: ordinal not in range(128)

Workaround:

The directory containing the plugin subdir had a french character in it (~/Téléchargement/fuel_plugin). Simply moving fuel_plugin subdir one level up solves the error and the plugin compiles normaly (~/fuel_plugin). So special characters should be avoided in the path for plugins.

Expected result:

The plugin should compile fine.

Either the documentation should reflect this or the fpb module should check for special characters in the path.

Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Andriy Popovych (popovych-andrey)
Changed in fuel:
importance: Undecided → Medium
milestone: none → 7.0
Changed in fuel:
status: New → Confirmed
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Workaround: do not use non-ascii symbols in patch. We can fix it in 8.0

Changed in fuel:
status: Confirmed → Won't Fix
assignee: Andriy Popovych (popovych-andrey) → Fuel Python Team (fuel-python)
tags: added: feature-plugins
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227837

Changed in fuel:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/227837
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=11d86d05ebe466d671ca91b6d3e8c7983c86f007
Submitter: Jenkins
Branch: master

commit 11d86d05ebe466d671ca91b6d3e8c7983c86f007
Author: Artem Roma <email address hidden>
Date: Fri Sep 25 16:08:10 2015 +0300

    Convert cli arguments to unicode objects

    This eliminates problem when non-ascii chars in plugin path led to
    encoding related errors in the build operation

    Change-Id: I382491426f3e4050021e4b837f87cd749e0d7363
    Closes-Bug: #1455196

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Reproduced on ISO #140

[root@fuel Téléchargement]# fpb --build fuel_plugin
Unexpected error
'ascii' codec can't decode byte 0xc3 in position 47: ordinal not in range(128)
[root@fuel Téléchargement]#

"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "4c58b6503fc780be117777182165fd7b037b1a96", "astute_sha": "e99368bd77496870592781f4ba4fb0caacb9f3a7", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "140", "build_number": "140", "auth_required": true, "fuel-library_sha": "6579c3debf9f1e8832cc6714aca0125b66d2bd7d", "fuel-nailgun-agent_sha": "d66f188a1832a9c23b04884a14ef00fc5605ec6d", "fuel-nailgun_sha": "46fbd9e21e91af057335cfa7e1f29159c1eb82ac", "fuel-agent_sha": "84335446172cc6a699252c184076a519ac791ca1", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "df6a93f7e2819d3dfa600052b0f901d9594eb0db", "api": "1.0", "fuelmain_sha": "4c58b6503fc780be117777182165fd7b037b1a96", "astute_sha": "e99368bd77496870592781f4ba4fb0caacb9f3a7", "fuel-ostf_sha": "983d0e6fe64397d6ff3bd72311c26c44b02de3e8", "openstack_version": "2015.1.0-8.0", "build_id": "140", "build_number": "140", "fuel-library_sha": "6579c3debf9f1e8832cc6714aca0125b66d2bd7d", "fuel-nailgun-agent_sha": "d66f188a1832a9c23b04884a14ef00fc5605ec6d", "fuel-nailgun_sha": "46fbd9e21e91af057335cfa7e1f29159c1eb82ac", "fuel-agent_sha": "84335446172cc6a699252c184076a519ac791ca1", "production": "docker", "python-fuelclient_sha": "769df968e19d95a4ab4f12b1d2c76d385cf3168c", "feature_groups": ["mirantis"], "release": "8.0"}}}

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Artem Roma (aroma-x) wrote :

@Anastasia, are you sure you have used fpb with merged fix? Because the issue is not reproducible on code which is currently in the master of fuel-plugins. Please, check that again. Until confirmation move this bug to invalid

Changed in fuel:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.