Progress bar is broken for multiroles with operating system

[Anastasia Palkina]

"build_id": "2015-05-08_10-07-32",
"build_number": "394",
"release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-08_10-07-32", "build_number": "394", "api": "1.0", "fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3", "nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97", "fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01", "release": "6.1", "fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"}}},
"auth_required": true,
"api": "1.0",
"fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3",
"nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537",
"feature_groups": ["mirantis"],
"openstack_version": "2014.2.2-6.1",
"production": "docker",
"python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce",
"astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97",
"fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01",
"release": "6.1",
"fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"

1. Create new environment (CentOS)
2. Choose Neutron, VLAN
3. Add 1 controller+operating system, 1 compute+operating system
4. Start deployment. It was successful
5. But progress bar is broken because after starting deployment progress bar for controller became 100% and for compute near 50%. And it remains until the end of deployment.

[Vladimir Sharshov (vsharshov)]

In case of multiroles all roles weight of role the same. 2 roles, both have 50%, 3 roles - 33%.

2015-05-12T15:41:57 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "status"=>"deploying", "role"=>"base-os", "progress"=>50, "task"=>{"priority"=>200, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/globals/globals.pp", "timeout"=>3600, "cwd"=>"/"}}}, {"uid"=>"6", "status"=>"deploying", "role"=>"base-os", "progress"=>50, "task"=>{"priority"=>200, "type"=>"puppet", "uids"=>["6"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/globals/globals.pp", "timeout"=>3600, "cwd"=>"/"}}}]}

After it both compute and primary-controller have progress, but we have here some anomaly. Progress bar raise too fast.

Controller:

2015-05-12T15:42:51 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "progress"=>50, "status"=>"deploying", "role"=>"primary-controller", "task"=>{"priority"=>300, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/globals/globals.pp", "timeout"=>3600, "cwd"=>"/"}}}]}
2015-05-12T15:42:59 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "progress"=>50, "status"=>"deploying", "role"=>"primary-controller", "task"=>{"priority"=>400, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/logging/logging.pp", "timeout"=>3600, "cwd"=>"/"}}}]}
2015-05-12T15:43:12 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "progress"=>57, "status"=>"deploying", "role"=>"primary-controller", "task"=>{"priority"=>500, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/tools/tools.pp", "timeout"=>3600, "cwd"=>"/"}}}]}
2015-05-12T15:43:14 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "progress"=>97, "status"=>"deploying", "role"=>"primary-controller", "task"=>{"priority"=>500, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/tools/tools.pp", "timeout"=>3600, "cwd"=>"/"}}}]}
2015-05-12T15:43:16 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"5", "progress"=>100, "status"=>"deploying", "role"=>"primary-controller", "task"=>{"priority"=>500, "type"=>"puppet", "uids"=>["5"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"/etc/puppet/modules/osnailyfacter/modular/tools/tools.pp", "timeout"=>3600, "cwd"=>"/"}}}]}

Compute:

2015-05-12T16:14:31 debug: [682] Data send by DeploymentProxyReporter to report it up: {"nodes"=>[{"uid"=>"6", "progress"=>50, "status"=>"deploying", "role"=>"compute", "task"=>{"priority"=>400, "type"=>"puppet"...

[Evgeniy L (rustyrobot)]

Doesn't look like a High.
1. it doesn't affect deployment in any way
2. in the most cases it doesn't make much sense to assign base-os role with any other role, because any other role already includes base-os

We won't be able to make here sooth progress bar because we don't have task based progress bar calculation.

[Vladimir Sharshov (vsharshov)]

Will be fixed on: https://blueprints.launchpad.net/fuel/+spec/progress-bar-based-on-tasks

[Vladimir Sharshov (vsharshov)]

Moved to 8.0, because it doesn't affect deployment in any way. It will be fixed in future: https://blueprints.launchpad.net/fuel/+spec/progress-bar-based-on-tasks

[Alexander Kislitsky (akislitsky)]

We passed SCF in 8.0. Moving the bug to 9.0.

[Vladimir Sharshov (vsharshov)]

Moving to Task Based Deployment solve the problem. Now progress bar calculated based on tasks which run on nodes.

[Alisa Tselovalnikova (atselovalnikova)]

Verified on http://paste.openstack.org/show/523595.

All steps are passed. Progress bar is not broken.