"fpb --build" command creates two packages instead of one

[Iryna Vovk]

Steps to reproduce:
1. Build plugin with command:
fpb --build <place_where_it_will_be_placed>

Result:
the two packages were created (the first and the second version)

Expected result:
should be one package with the first version

Additional info:
ivovk@user-All-Series:~/git/fuel-plugin-contrail$ cd ..
ivovk@user-All-Series:~/git$ fpb --build fuel-plugin-contrail/
Plugin is built
ivovk@user-All-Series:~/git$ cd fuel-plugin-contrail/
ivovk@user-All-Series:~/git/fuel-plugin-contrail$ ls
contrail-1.0-1.0.0-0.noarch.rpm
contrail-1.0-1.0.0-1.noarch.rpm

[Nastya Urlapova (aurlapova)]

Could you please add Fuel version?

[Sebastian Kalinowski (prmtl)]

Please specify version of Fuel Plugin Builder and commit of fuel-plugin-contrail on which it was observed.

[Sebastian Kalinowski (prmtl)]

I've reproduced it with fpb 2.0.0 and fuel-contrail-plugin ee7fbf8d2a99b3ebc10784d77187f11762149592

[Iryna Vovk (ivovk)]

I observed it with fuel-plugin-builder 2.0.0 and commit 5901a8f4c2f15b9f02ea4ef7eaaf6aaf4b53ed8a

[Sebastian Kalinowski (prmtl)]

Bug appear if developer used development version of fuel-plugin-builder, before commit https://github.com/stackforge/fuel-plugins/commit/8056c7edc1dff7d660421c6d047e4d3956e7b50e, to build plugin and then used a newer one to build it.

Produced RPMs are stored in plugin-name/.build/rpm/RPMS dir, which was not cleaned, so with older version of plugin
we got contrail-1.0-1.0.0-0.noarch.rpm and after using new contrail-1.0-1.0.0-1.noarch.rpm. In the build process all RPMs from build dir are copied to plugin base dir which is observed as "building two versions of plugin".

Solution is to simply clean rpm build dir.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/180455

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/180455
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=2be481c352f8c5aa725828b4c2ca3f991d2bc990
Submitter: Jenkins
Branch: master

commit 2be481c352f8c5aa725828b4c2ca3f991d2bc990
Author: Sebastian Kalinowski <email address hidden>
Date: Wed May 6 11:11:20 2015 +0200

    Clean build dir before building plugin package

    If there are some artifacts left in build dir, for example old
    RPMs may cause different side effects like having two version of
    packages of the same plugin in the end of the build.

    Change-Id: I427065cad0c1e610b637d312e91c60fd521ea14e
    Closes-Bug: #1451751

[Vladimir Khlyunev (vkhlyunev)]

Verified on master branch of stackforge/fuel-plugins