Accept Infiniband child Interfaces in network_scheme and L23 network

[Aviram Bar-Haim]

Currently in l23 network, when using IB child interfaces as endpoints, e.g. ib0.8002, it looks for vlan 8002 because it accepts only ETH ports.

[Vladimir Kuklin (vkuklin)]

Aviram, could you please contact Stanislav Makar and figure out the place you would like to change in l23network module?

[Aviram Bar-Haim (aviramb)]

The only thing needed is to accept endpoints / interfaces of the form ibx.80yz . currently l23network fails for these interfaces since it tries to verify 80yz is a valid vlan, and there isn't any other way to define non Ethernet interfaces...

I discussed about it with Sergey Vasilenko and in Mellanox plugin we currently have a workaround that uses l23_stored_config and then executing ifdown ifup.

[Evgeniya Shumakher (eshumakher)]

Aviram, please describe the workaround.
In case this is a plugin bug, please use the following LP project: https://bugs.launchpad.net/fuel-plugins

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/182721

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/182721
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=78769e5399cb5236cff79b9a8b7089de451c12c6
Submitter: Jenkins
Branch: master

commit 78769e5399cb5236cff79b9a8b7089de451c12c6
Author: Sergey Vasilenko <email address hidden>
Date: Wed May 13 08:20:10 2015 -0700

    Add possibility for devices with names like "xxxNNN.XXX"

    to be not an 802.1q vlan interfaces
    by defining

        vlan_dev: false

    in network scheme

    Change-Id: Ic2740c7187714c511fb7c58a10b173b65dda5d2b
    Closes-bug: #1450420

[Aviram Bar-Haim (aviramb)]

Reproduced in Fuel 8.0 GA:
root@node-4:/etc/fuel/plugins/mellanox-plugin-2.0# puppet apply -d /etc/puppet/modules/osnailyfacter/modular/netconfig/netconfig.pp
.
.
Error: Parameter vlan_id failed on L23_stored_config[ib0.8002]: '8002' is not a valid 802.1q NALN_ID (must be a integer value in range (0 .. 4094) at /etc/puppet/modules/l23network/manifests/l3/ifconfig.pp:176

root@node-4:/etc/fuel/plugins/mellanox-plugin-2.0# hiera network_scheme
{"endpoints"=>
  {"br-ex"=>{"IP"=>["10.209.37.226/22"], "gateway"=>"10.209.36.1"},
   "br-floating"=>{"IP"=>"none"},
   "br-fw-admin"=>{"IP"=>["10.20.0.5/24"]},
   "br-mgmt"=>{"IP"=>["192.168.0.3/24"]},
   "br-prv"=>{"IP"=>"none"},
   "br-storage"=>{"IP"=>"None"},
   "ib0.8002"=>{"IP"=>["192.168.1.3/24"]}},
 "interfaces"=>
  {"enp2s0"=>{"vendor_specific"=>{"bus_info"=>"ib0", "driver"=>"eth_ipoib"}},
   "enp2s0d1"=>{"vendor_specific"=>{"bus_info"=>"ib1", "driver"=>"eth_ipoib"}},
   "enp6s0f0"=>
    {"vendor_specific"=>{"bus_info"=>"0000:06:00.0", "driver"=>"igb"}},
   "enp6s0f1"=>
    {"vendor_specific"=>{"bus_info"=>"0000:06:00.1", "driver"=>"igb"}},
   "ib0.8002"=>{}},
 "provider"=>"lnx",
 "roles"=>
  {"admin/pxe"=>"br-fw-admin",
   "ceilometer/api"=>"br-mgmt",
   "ceph/public"=>"br-mgmt",
   "ceph/radosgw"=>"br-ex",
   "ceph/replication"=>"ib0.8002",
   "cinder/api"=>"br-mgmt",
   "cinder/iscsi"=>"ib0.8002",
   "ex"=>"br-ex",
   "fw-admin"=>"br-fw-admin",
   "glance/api"=>"br-mgmt",
   "heat/api"=>"br-mgmt",
   "horizon"=>"br-mgmt",
   "ironic/api"=>"br-mgmt",
   "keystone/api"=>"br-mgmt",
   "management"=>"br-mgmt",
   "mgmt/corosync"=>"br-mgmt",
   "mgmt/database"=>"br-mgmt",
   "mgmt/memcache"=>"br-mgmt",
   "mgmt/messaging"=>"br-mgmt",
   "mgmt/vip"=>"br-mgmt",
   "mongo/db"=>"br-mgmt",
   "murano/api"=>"br-mgmt",
   "murano/cfapi"=>"br-mgmt",
   "neutron/api"=>"br-mgmt",
   "neutron/floating"=>"b...

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/322888

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322888
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=27adf49103a8515e8204f30922440314a0fa97bb
Submitter: Jenkins
Branch: master

commit 27adf49103a8515e8204f30922440314a0fa97bb
Author: Sergey Vasilenko <email address hidden>
Date: Mon May 30 16:44:17 2016 +0300

    handle infiniband NICs naming, which looks like

    native linux subinterface

    + some typo fix
    + tests improvements

    Change-Id: Ie1eff9adbfcff29bf16d3320a760ed7d14f552b8
    Closes-bug: #1450420

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323370
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ef7efb0c64ba611b6b223443d0cae8fd25f5d443
Submitter: Jenkins
Branch: stable/mitaka

commit ef7efb0c64ba611b6b223443d0cae8fd25f5d443
Author: Sergey Vasilenko <email address hidden>
Date: Mon May 30 16:44:17 2016 +0300

    handle infiniband NICs naming, which looks like

    native linux subinterface

    + some typo fix
    + tests improvements

    Change-Id: Ie1eff9adbfcff29bf16d3320a760ed7d14f552b8
    Closes-bug: #1450420
    (cherry picked from commit 27adf49103a8515e8204f30922440314a0fa97bb)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/324378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324378
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e65c49dbb0223a13e60cac6778d42d9bfa25ff8c
Submitter: Jenkins
Branch: stable/8.0

commit e65c49dbb0223a13e60cac6778d42d9bfa25ff8c
Author: Sergey Vasilenko <email address hidden>
Date: Mon May 30 16:44:17 2016 +0300

    handle infiniband NICs naming, which looks like

    native linux subinterface

    + some typo fix
    + tests improvements

    Change-Id: Ie1eff9adbfcff29bf16d3320a760ed7d14f552b8
    Closes-bug: #1450420
    (cherry picked from commit 27adf49103a8515e8204f30922440314a0fa97bb)
    (cherry picked from commit ef7efb0c64ba611b6b223443d0cae8fd25f5d443)