WebUI doesn't check a field type during regex validation

[Andrey Danin]

Reproduced for ISO 6.0 GA release.
Maybe 6.1 branch is also affected.

If regexs are present for a cluster attribute and 'value' is not a string, the Cluster Settings tab doesn't show up when you click on it.
In a JS console a message appears:
"TypeError: e.value.match is not a function main.js:307:11695"
This is the code where the error occurs:
"e.regex&&e.regex.source&&!s(r)&&(e.value.match(new RegExp(e.regex.source))||(n[r]=e.regex.error))},this)},this),_.isEmpty(n)?null:n}"

How to reproduce:
1) download cluster settings via fuel-cli.
2) change ['storage']['osd_pool_size']['value'] from '2' (string) to 2 (int).
3) upload the settings.
4) try to look at them via WebUI.

The best place to fix it it's a backend. Nailgun shouldn't accept such invalid data.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176653

[Vitaly Kramskikh (vkramskikh)]

This must be fixed by introducing of validation of JSON schema, so settings with number in the value won't be saved. UI can't just cover all the cases with invalid data. What if there would be null value? Boolean? Array of numbers?

[Vitaly Kramskikh (vkramskikh)]

As a last resort solution, I can merge the proposed UI change to fix this particular issue. But this could trigger similar issues in other places - some puppet manifests could also expect a string there

[Andrey Danin (gcon-monolake)]

Agree. It's should be fixed on a backend side. Unfortunately, I cannot validate it right now against 6.1.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julia Aranovich (<email address hidden>) on branch: master
Review: https://review.openstack.org/176653
Reason: The issuw will be fixed on backend.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178101

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178101
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=c83e79f06b41cef48f86f19066cee4f35d9b32df
Submitter: Jenkins
Branch: master

commit c83e79f06b41cef48f86f19066cee4f35d9b32df
Author: Przemyslaw Kaminski <email address hidden>
Date: Tue Apr 28 10:45:13 2015 +0200

    Validate cluster attributes

    Add validation for cluster attributes. Do it so that it doesn't break
    compatibility with current tests. Validate regexpes if they are provided.

    Change-Id: I9c1fc04dab45aecf3e32615172654d11844df7c3
    Closes-Bug: #1447407

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 6.0-updates as this is feature request not a bug