Extra and main ubuntu repos priority issue

[Bogdan Dobrelya]

When some extra Ubuntu repo is added in UI with some priority, deployed Ubuntu nodes show unexpected priorities in apt-cache policy output. For example (see attached screenshot), the external repo is:

# cat /etc/apt/sources.list.d/mos-test.list
deb http://obs-1.mirantis.com:82/trusty-fuel-6.1-stable-5388/reprepro/ trusty main

# cat /etc/apt/preferences.d/mos-test
Package: *
Pin: release a=trusty,c=main
Pin-Priority: 1150

# apt-cache policy corosync
corosync:
  Installed: 2.3.3-1ubuntu1
  Candidate: 2.3.3-1ubuntu1
  Version table:
     2.3.4-0u~u14.04+mos1 0
        500 http://obs-1.mirantis.com:82/trusty-fuel-6.1-stable-5388/reprepro/ trusty/main amd64 Packages
 *** 2.3.3-1ubuntu1 0
       1100 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
        100 /var/lib/dpkg/status

But if I changed the preferences pinning to:

# cat /etc/apt/preferences.d/mos-test
Package: *
Pin: release n=trusty*
Pin-Priority: 1150

It would show an expected candidate now:

# apt-cache policy corosync
corosync:
  Installed: 2.3.3-1ubuntu1
  Candidate: 2.3.4-0u~u14.04+mos1
  Package pin: 2.3.4-0u~u14.04+mos1
  Version table:
     2.3.4-0u~u14.04+mos1 1150
        500 http://obs-1.mirantis.com:82/trusty-fuel-6.1-stable-5388/reprepro/ trusty/main amd64 Packages
 *** 2.3.3-1ubuntu1 1150
       1100 http://archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
        100 /var/lib/dpkg/status

[Bogdan Dobrelya (bogdando)]

Note, this issue may be not valid for official mirrors, but our QA team should have a clearly documented way to test OBS test repos

[Bogdan Dobrelya (bogdando)]

@Aleksandr, please explain why you assign this to Fuel library. Puppet does not configure Ubuntu repos in Fuel currently

[Alexei Sheplyakov (asheplyakov)]

nailgun generates a broken pinning rules. MOS Linux has nothing to do with that.

[Alexei Sheplyakov (asheplyakov)]

The code which generates broken pinning rules: https://review.openstack.org/166774

[Alexei Sheplyakov (asheplyakov)]

Looks like a duplicate of https://bugs.launchpad.net/fuel/+bug/1438783

[Bogdan Dobrelya (bogdando)]

could be related as well https://bugs.launchpad.net/fuel/+bug/1447071

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/175358
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=46cd6a8d8e943669e4cb7557551a3e4eeae0019c
Submitter: Jenkins
Branch: master

commit 46cd6a8d8e943669e4cb7557551a3e4eeae0019c
Author: Igor Kalnitsky <email address hidden>
Date: Wed Apr 15 18:05:45 2015 +0300

    Implement advanced apt pinning

    Current approach is an error prone, because Debian repos may contain
    metadata that doesn't fit our pinning template. Yes, in some cases
    our template will work (and it does with upstream Ubuntu and Fuel),
    but we want to be flexible and cover all cases.

    In order to set corrent pinning, we have to use repo's metadata and
    that means download repo's Release file, parse it and create pinning
    based on it. In that case we'll use all available pinning rules, so
    all possible issues will be up to repo maintainer and not because
    we're using error prone approach.

    Related-Bug: #1435892
    Related-Bug: #1438783
    Closes-Bug: #1446686

    Change-Id: I5279b7f414f831503fd993109dd5c91bef51a9ef
    Signed-off-by: Igor Kalnitsky <email address hidden>

[Bogdan Dobrelya (bogdando)]

I tested this fix with the ISO #338 and now the pinning looks good, as for me. Thank you!