Nailgun start check (run_server in run_tests.sh) doesn't work properly

Bug #1446211 reported by Vitaly Kramskikh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Roman Prykhodchenko

Bug Description

It happens on slow machines and/or in VMs. In this case there is just a message "Failed to start Nailgun".

To avoid this issue, I propose the following changes:

1) Increase number of check attempts from 10 to 30-50
2) Print explicit error message in case of timeout

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

It seems it is possible to control timeout by setting env var NAILGUN_START_MAX_WAIT_TIME, but explicit message is still needed

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

It seems this check doesn't work at all as it uses $NAILGUN_CHECK_URL which uses $NAILGUN_PORT instead of $UI_SERVER_PORT. So it always waits for 5s.

summary: - Non-inormative message in webui/fuel-cli tests if nailgun failed to
- start due to timeout
+ Nailgun start check (run_server in run_tests.sh) doesn't work properly
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Fuel Python Team (fuel-python)
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

Vitaly, could you please describe, what information should be added to the message?

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Roman Prykhodchenko (romcheg)
Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

I think there should be a common message like "Nailgun didn't start in ${NAILGUN_START_MAX_WAIT_TIME}s. Use NAILGUN_START_MAX_WAIT_TIME var to increase timeout". In case of non-timeout failure there could be a path to log file

Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

Thank's for your response. I'll publish a patch soon.

Changed in fuel:
status: Incomplete → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/175961

Changed in fuel:
status: Triaged → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: module-nailgun tech-debt
removed: nailgun
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/175961
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9d7e7247e44b1b73fe293f5b020a41fc70697a1d
Submitter: Jenkins
Branch: master

commit 9d7e7247e44b1b73fe293f5b020a41fc70697a1d
Author: Roman Prykhodchenko <email address hidden>
Date: Tue Apr 21 17:57:50 2015 +0200

    Refactored run_server script

    Used the updated version of run_server script
    from python-fuelclient.

    Closes-bug: #1446211
    Change-Id: I2c8538fa6e3854f2c33434a1b08d366121cc55b1

Changed in fuel:
status: In Progress → Fix Committed
Nikolay Markov (nmarkov)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.