Neutron integration and tunneling bridges are created in the wrong way

[Sergey Kolekonov]

Since l23::network refactoring has been merged, Neutron integration and tunnel bridges are created in Puppet manifests as Linux bridges. These bridges must be created as OVS bridges, but it would be better to not to create them from Puppet at all, because Neutron manages them itself. Look at the source code [1] [2]
Such behavior also confuses end-users because they will see int and tun bridges both as Linux and as OVS and they are independent.

I suggest either to remove bridges addition from Puppet manifests or to specify the correct provider (ovs).
Corresponding bug in upstream manifests is here [3]

[1] https://github.com/openstack/neutron/blob/stable/juno/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py#L698-L710
[2] https://github.com/openstack/neutron/blob/stable/juno/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py#L747-L758
[3] https://bugs.launchpad.net/puppet-neutron/+bug/1436422

[Sergey Vasilenko (xenolog)]

FIX shouldn't be backported to earlier releases.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170838

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/174813

[Bogdan Dobrelya (bogdando)]

This blocks CI jobs, so raised to critical

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/174813
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=91ee597bb247b90a8c0cbd0c8870343f01037888
Submitter: Jenkins
Branch: master

commit 91ee597bb247b90a8c0cbd0c8870343f01037888
Author: Sergey Vasilenko <email address hidden>
Date: Fri Apr 17 14:01:00 2015 +0300

    Make package 'bridge-utils' usage safe

    When using puppet-nova with another big Puppet modules
    this package may be defined before.

    The solution is to make a definition safe.

    Upstream-bug: https://bugs.launchpad.net/puppet-nova/+bug/1445437

    Fuel-CI: disable
    Related-bug: #1440681
    Change-Id: Ie1dc7c9d6b2b05802b38974d6303b41f035676ab

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170838
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=110e12cc72f5c681c9b334afbb13f5ff72d50e51
Submitter: Jenkins
Branch: master

commit 110e12cc72f5c681c9b334afbb13f5ff72d50e51
Author: Sergey Vasilenko <email address hidden>
Date: Mon Apr 6 15:59:19 2015 +0300

    L23network related fixes:

    * l23network module initialization for granular deployment
    * wrong bridge type while creating integration and tun bridge.
    * bug/1446187

    Note: After refactoring L23network module default provider
    for bridges was changed from 'ovs' to 'lnx', but Neutron
    requires 'ovs' bridges in any way.
    Neutron no more need for creating br-int and br-tun
    (upstream-bug: https://bugs.launchpad.net/puppet-neutron/+bug/1436422)

    Change-Id: Ib28558f64111c967cfdd1b6ed1a2008b5767cb87
    Closes-bug: #1440681
    Closes-bug: #1446187
    Closes-bug: #1447665
    Closes-bug: #1447085
    Closes-bug: #1448157

[Stanislav Makar (smakar)]

Verified

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "478"
  build_id: "2015-05-28_20-55-26"
  nailgun_sha: "4344fe68b5c93d2e7f7254076aab62aa3a612e42"
  python-fuelclient_sha: "e19f1b65792f84c4a18b5a9473f85ef3ba172fce"
  astute_sha: "5d570ae5e03909182db8e284fbe6e4468c0a4e3e"
  fuel-library_sha: "09822a44c2298437882062a43c8ab0bcef952524"
  fuel-ostf_sha: "6b4ddbfd3126b77f79759721e86d395bf106b177"
  fuelmain_sha: "6b5712a7197672d588801a1816f56f321cbceebd"