Enforce rpm name format for plugins in fpb

Bug #1439116 reported by Vyacheslav Struk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Triaged
Medium
Fuel Sustaining

Bug Description

How to reproduce:

install fpb 38db815(master)
go to plugin dir, execute "fpb --build ."

fpb generates rpm named: "contrail-1.0-1.0.0-0.noarch.rpm"

Proposed solution:

Fix spec template:
Use ${name}-${version} format, i.e. contrail-1.0.0-0.noarch.rpm

description: updated
Dmitry Pyzhov (dpyzhov)
tags: added: feature-plugins
Changed in fuel:
milestone: none → 6.1
assignee: nobody → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Vladimir Sharshov (vsharshov)
description: updated
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

Just some feedback about plugin package naming.
I would love to see a common convention, so that it is very obvious to tell that this package is a Fuel plugin and what format it is written in. Let's look at yum plugins for example.
They follow the naming of yum-plugin-$pluginname-$version-$release
We should try to name Fuel plugins this way:
fuel-plugin-$pluginfmtver.$pluginver-$release.noarch.rpm
Let's just agree that the major version of the package should correspond with the plugin format. It's the most important value here in any case. The release should always start at 1, but it could include a git hash.
The plugins themselves should do some check to ensure the nailgun API version meets its requirements before they can be fully registered into Fuel.

With regards to this, I think we should agree that an initial release version of the Fuel Contrail plugin should be the following:
fuel-plugin-contrail-1.1.0-1.noarch.rpm

Changed in fuel:
importance: Medium → High
Revision history for this message
Evgeniy L (rustyrobot) wrote :

Matthew, Vyacheslav, RPM was named this way because 1.0 is a part of rpm name, "contrail-1.0", and after that goes the version "contrail-1.0-1.0.0", with such approach "contrail-1.0" and "contrail-1.1" plugins can be installed at the same time and can be used for different environments.

Implementation of "fuel-plugin" prefix will require to fix fpb and fuel client.

Release version is easy to fix replace 0 with 1
https://github.com/stackforge/fuel-plugins/blob/master/fuel_plugin_builder/fuel_plugin_builder/templates/build/plugin_rpm.spec.mako#L19

tags: added: tricky
Changed in fuel:
assignee: Vladimir Sharshov (vsharshov) → Fuel Python Team (fuel-python)
importance: High → Medium
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.1 → 7.0
tags: added: feature
Revision history for this message
Evgeniy L (rustyrobot) wrote :

Extracted part release in separate ticket https://bugs.launchpad.net/fuel/+bug/1444977

Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Does not affect deployment. Moving to 8.0

tags: added: known-issue
Changed in fuel:
status: Confirmed → Won't Fix
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
Alexander Kislitsky (akislitsky) wrote :

We passed SCF in 8.0. Moving the bug to 9.0.

Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

It's a feature and we passed SCF for 9.0. Moving to 10.0.

summary: - plugin builder generates wrong rpm filename
+ Enforce rpm name format for plugins in fpb
Changed in fuel:
milestone: 9.0 → 10.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python (Deprecated) (fuel-python) → Fuel Sustaining (fuel-sustaining-team)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.