Fuel for OpenStack

--tests option in run_tests.sh in nailgun returns 0 regardless of test result.

Bug #1439057 reported by Maciej Kwiek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Sebastian Kalinowski
Fuel for OpenStack 8.0

Bug Description

To reproduce: find a non-passing test or add self.assertTrue(False) in any test and run it using -t|--test option. Test will fail, but status code returned by script will be 0.

Found on a3c259a4875787274fa01f0eba6514cc01b34308.

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: none → 6.1
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We are going to split our fuel-web repo in 7.0. It will simplify our run-tests.sh

Changed in fuel:
milestone: 6.1 → 7.0
Nastya Urlapova (aurlapova)
tags: added: qa-agree-7.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225700

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Sebastian Kalinowski (prmtl)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/225700
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7e8b35076f79fc9a306c2a55d614de3d0ad58fc2
Submitter: Jenkins
Branch: master

commit 7e8b35076f79fc9a306c2a55d614de3d0ad58fc2
Author: Sebastian Kalinowski <email address hidden>
Date: Mon Sep 21 16:13:05 2015 +0200

    Right exit code when running only selected tests

    Many "echos" were hiding exit code returned by tox

    Change-Id: I0e7ed985f61d19cd528544116f5d6bf8048b3c77
    Closes-Bug: #1439057

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Vladimir (vushakov)
tags: added: on-verification
Revision history for this message
Vladimir (vushakov) wrote :

Verified on Fuel 8.0 build.
Environment created by system_tests.sh. A test case was broken with 'self.assertTrue(False)', nailgun execution failed. Exit code was 1

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "207"
  build_id: "207"
  fuel-nailgun_sha: "beec500b254fdadcce83767c01e8a80e40aee797"
  python-fuelclient_sha: "3e7738fd3fb18a2d5f53b1ecc9706dc53b65a511"
  fuel-agent_sha: "d96ed1d854166be6da5c7fafa299b0a3feda8c42"
  fuel-nailgun-agent_sha: "b56f832abc18aee9a8c603fd6cc2055c5f4287bc"
  astute_sha: "d2c1b401816c6f0341902272f37018b9cec3c775"
  fuel-library_sha: "ae564d690bfa1883f4c79182ac43ee6a5b21cd44"
  fuel-ostf_sha: "6bcb28b3196b34256f12c3f11cbe592e746d4dae"
  fuel-createmirror_sha: "9b335c8d551c87d788166947cb7ed519757881e8"
  fuelmenu_sha: "9627849843e84b7f01c44bd79898a8d62d96ce66"
  shotgun_sha: "a3d413d1ca411ddd5c26c850932b99c5e33ca17f"
  network-checker_sha: "2c62cd52655ea6456ff6294fd63f18d6ea54fe38"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "a262fc9460d92f410e4fc0c8db150592059b4b4d"

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.